Skip to content

SIDECAR_ENABLE_LOGGING flag is inverted #523

Description

@cguedes

Noticed that this code is using the incorrect (inverted) logic to disable/enable the logger.
@gjreda can you confirm?

logger.disabled = os.environ.get("SIDECAR_ENABLE_LOGGING", "false").lower() == "true"

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpythonPull requests that update Python code

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions