[Cleaner Version] Support for Certificate Compression Algorithm extension in Certificate Request Message#348
Merged
mingyech merged 3 commits intorefraction-networking:masterfrom Jun 21, 2025
Conversation
Contributor
|
I have tested this and it works on my end! |
mingyech
reviewed
Jun 10, 2025
Member
mingyech
left a comment
mingyech
left a comment
There was a problem hiding this comment.
Thank you for contributing! It looks good to me, just have a few nit picks.
handshake_messages.go
Outdated
| } | ||
|
|
||
| type certificateRequestMsgTLS13 struct { | ||
| original []byte |
Member
examples/ech/sslkeylogging.log
Outdated
handshake_messages.go
Outdated
| scts bool | ||
| supportedSignatureAlgorithms []SignatureScheme | ||
| supportedSignatureAlgorithmsCert []SignatureScheme | ||
| certRequestCompressionAlgs []CertCompressionAlgo |
Member
There was a problem hiding this comment.
It looks like you also have your second approach of fixing this from #345 (comment) in here as well with the original and originalBytes(), could we remove the first approach if it works without it? It's a good reference in case we need to actually implement this in the future but I think your new approach is better.
Contributor
Author
|
Thank you for your review! Good ideas! I am keeping only the second approach using original bytes and solve the testing problem in the most recent commit. |
mingyech
force-pushed
the
fix/cleaned-cert-req-compress-ext
branch
from
aebc85a to
5abccec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to do the same functionality as my previous pr #347 but for a cleaner commit history. Hence the following description is copied from previous pr.
This version introduces a new CertCompressionAlgo implementation for certificateRequestMsgTLS13 in handshake_messages.go, addressing issue #345.
The change resolves the error: 'tls: invalid signature by the server certificate: crypto/rsa: verification error'
which occurs when connecting to servers that include a certificate compression algorithm extension in the CertificateRequest message during the TLS 1.3 handshake.
@BRUHItsABunny — would you mind testing this on your end to confirm the fix works as expected?