Skip to content

Comments

feat: generate different ecdhe key for pq key#343

Merged
mingyech merged 1 commit intomasterfrom
pq-key-fix
May 14, 2025
Merged

feat: generate different ecdhe key for pq key#343
mingyech merged 1 commit intomasterfrom
pq-key-fix

Conversation

@mingyech
Copy link
Member

Closes #342

When the client sends both pq and non-pq keyshares, the ecdhe key was
reused in line with stdlib. However this can be used to fingerprint utls
ClientHellos. Generate different ecdhe keys instead, in line with
Chrome. This will have to change when we support more browsers with
different ways of handling this.
@mingyech mingyech merged commit dbca939 into master May 14, 2025
3 checks passed
@mingyech mingyech deleted the pq-key-fix branch May 14, 2025 22:45
@RPRX
Copy link
Contributor

RPRX commented May 16, 2025

感谢快速响应并修复!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[URGENT] Maybe uTLS is reusing the same x25519EphemeralKey for both X25519MLKEM768 and X25519, unlike Chrome

2 participants