Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables ECH when the user provides a ClientHello spec that has an extension implementing the
EncryptedClientHelloExtensioninterface (such as theGREASEEncryptedClientHelloExtensioncurrently for all the browsers) and follows the standard library’s ECH API of providing theEncryptedClientHelloConfigListin the config.When ECH is enabled, we generate another ClientHello as the ClientHelloInner using the standard library’s handshake marshaling functions and encode it in our ClientHelloOuter. Some extensions are substituted in the OuterExtensions list, in which case the uTLS generated values in the ClientHelloOuter will be used. We reorder the OuterExtensions list according to the structure in the outer ClientHello spec.