Skip to content

Comments

Add Chrome 131 parrot and ML-KEM support#322

Merged
mingyech merged 3 commits intorefraction-networking:masterfrom
BRUHItsABunny:master
Mar 14, 2025
Merged

Add Chrome 131 parrot and ML-KEM support#322
mingyech merged 3 commits intorefraction-networking:masterfrom
BRUHItsABunny:master

Conversation

@BRUHItsABunny
Copy link
Contributor

ML-KEM is now part of Chrome 131 as foreshadowed here:
https://security.googleblog.com/2024/09/a-new-path-for-kyber-on-web.html

I added it as HelloChrome_131 instead of HelloChrome_131_PQ because post quantum is enabled by default but I'm open to changes.

@BRUHItsABunny BRUHItsABunny marked this pull request as ready for review December 30, 2024 06:20
@mingyech
Copy link
Member

Thank you for the PR! Given that go 1.24 is about to be released and has its own implementation of MLKEM, I think the move here is to wait until that gets merged instead of building on cloudflare's fork. That said the chrome parrot part of this PR is still useful. Lets keep this PR open and revisit after merging 1.24.

@RPRX
Copy link
Contributor

RPRX commented Feb 25, 2025

来催更了

@BRUHItsABunny
Copy link
Contributor Author

@mingyech I see that go 1.24 has been merged in now. Does this mean ML-KEM is now fully supported without the CloudFlare dependency?

@mingyech
Copy link
Member

@BRUHItsABunny Yes, and I think this is ready to be merged. Would you do a rebase onto master removing the cloudflare changes?

@BRUHItsABunny
Copy link
Contributor Author

Rebased it, it passes my internal testing primarily to see if the TLS fingerprint of Chrome 131+ is showing up as expected.
Can you run the repo workflow and see if the unit tests pass?

@RPRX
Copy link
Contributor

RPRX commented Mar 13, 2025

Commit history 有点混乱,你应当先 reset 到 5ce39b8 ,再 push u_common.go 和 u_parrots.go 的总计 75 additions

5ce39b8...BRUHItsABunny:utls:7d5b6c6

以及 HelloChrome_Auto 也要改为指向 HelloChrome_131

@mingyech
Copy link
Member

@BRUHItsABunny Thanks! And workflow approved, sorry for the late reply.
I second what @RPRX said about fixing the git history, and also HelloChrome_Auto if you don't mind adding a commit updating it. Let me know if you run into troubles.

@mingyech
Copy link
Member

Actually it looks like you did the rebase correctly but added a redundant merge. So if you remove the merge by resetting to 9d151db the history should be clean.
Screenshot 2025-03-13 at 5 46 46 PM

@BRUHItsABunny
Copy link
Contributor Author

Cool, should be good now

@mingyech
Copy link
Member

Thank you!

@mingyech mingyech merged commit e430876 into refraction-networking:master Mar 14, 2025
3 checks passed
@BRUHItsABunny
Copy link
Contributor Author

Nice, btw @mingyech with all the recent changes, should we release a new release/tag or not yet?

@mingyech
Copy link
Member

We might tag after merging #331 (hopefully soon) so that users won't get confused why ech isn't working

@RPRX
Copy link
Contributor

RPRX commented Mar 15, 2025

@mingyech 非常感谢你的工作,维护这样的项目并不是一件容易的事情,我尝试将 REALITY 仓库升至 Go 1.24 结果发现有大量对 crypto/internal 的 require,我想我可以参考你的工作

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants