Fix Config.InsecureSkipTimeVerify not being respected#303
Merged
gaukas merged 1 commit intorefraction-networking:masterfrom Jul 16, 2024
Merged
Fix Config.InsecureSkipTimeVerify not being respected#303gaukas merged 1 commit intorefraction-networking:masterfrom
gaukas merged 1 commit intorefraction-networking:masterfrom
Conversation
gaukas
approved these changes
Jul 16, 2024
Contributor
gaukas
left a comment
gaukas
left a comment
There was a problem hiding this comment.
Thanks for the nice catch! Currently uTLS has inadequate test coverage which leads to bug risks as such.
Contributor
|
If no more edits are going to be made on this pull request, I will be merging it by the end of day. Let me know before that if you want me to hold @adotkhan. |
Contributor
Author
|
Thanks for the quick review. |
sardanioss
pushed a commit
to sardanioss/utls
that referenced
this pull request
Jan 16, 2026
…y check (refraction-networking#303) Signed-off-by: adotkhan <[email protected]> Reviewed-by: Gaukas Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where server cert expiry is verified even though
Config.InsecureSkipTimeVerifyis set to true.It seems that this issue has come about after the uTLS sync with Go 1.21, where the upstream crypto/tls has moved the code to verify server cert expiry above the InsecureSkipVerify check.