Skip to content

Comments

quic: always use empty session ID#297

Merged
gaukas merged 1 commit intomasterfrom
fix-quic-must-use-empty-session-id
May 3, 2024
Merged

quic: always use empty session ID#297
gaukas merged 1 commit intomasterfrom
fix-quic-must-use-empty-session-id

Conversation

@gaukas
Copy link
Contributor

@gaukas gaukas commented May 3, 2024

by RFC 9000 Section 8.4, QUIC must not send non-empty (legacy) session ID, otherwise server will return error.

  • It is also weird that so far we see no error from server due to uquic sending 32-byte session ID.

by RFC 9000 Section 8.4, QUIC must not send non-empty (legacy) session ID, otherwise server will return error.

* It is also weird that so far we see no error from server due to uquic sending 32-byte session ID.

Signed-off-by: Gaukas Wang <[email protected]>
@gaukas gaukas added the bug Unexpected behavior confirmed and should be fixed label May 3, 2024
@gaukas gaukas requested a review from sippejw May 3, 2024 02:34
@gaukas gaukas self-assigned this May 3, 2024
Copy link
Member

@sippejw sippejw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for fixing this @gaukas!

@gaukas gaukas merged commit 4f71339 into master May 3, 2024
@gaukas gaukas deleted the fix-quic-must-use-empty-session-id branch May 3, 2024 14:39
gaukas added a commit that referenced this pull request May 3, 2024
adotkhan pushed a commit to Psiphon-Labs/utls that referenced this pull request Dec 10, 2024
adotkhan pushed a commit to Psiphon-Labs/utls that referenced this pull request Dec 10, 2024
adotkhan pushed a commit to Psiphon-Labs/utls that referenced this pull request Feb 5, 2025
sardanioss pushed a commit to sardanioss/utls that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior confirmed and should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants