ENG-8664: MutableProxy.wrap_recursive fully rebinds existing proxy values#6083
Merged
ENG-8664: MutableProxy.wrap_recursive fully rebinds existing proxy values#6083
Conversation
…lues This will convert ImmutableMutableProxy to MutableProxy for example when a value is stashed from a background event, then is accessed from a regular event.
Contributor
Greptile SummaryFixed
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant BG as Background Event
participant SP as StateProxy
participant IMP as ImmutableMutableProxy
participant MP as MutableProxy
participant State as BaseState
Note over BG,State: Background event stores value
BG->>SP: async with state_proxy
SP->>State: Access data["b"]
State-->>SP: Returns ImmutableMutableProxy
SP->>SP: state_proxy.data["a"] = state_proxy.data["b"]
Note over SP: Stores ImmutableMutableProxy to data["a"]
Note over BG,State: Regular event accesses stored value
BG->>State: Access wrapped state.data["a"]
State->>MP: _wrap_recursive(ImmutableMutableProxy)
MP->>MP: Detect isinstance(value, MutableProxy)
MP->>MP: Unwrap: value = value.__wrapped__
MP->>MP: Rewrap with current state reference
MP-->>State: Return new MutableProxy (not ImmutableMutableProxy)
Note over MP: State reference properly updated
|
adhami3310
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will convert ImmutableMutableProxy to MutableProxy for example when a value is stashed from a background event, then is accessed from a regular event.