CodSpeed Performance Report

Merging #6027 will not alter performance

_{Comparing fix-test-lifespan-on-prod (f2232e3) with main (fad67cf)}

Summary

✅ 8 untouched

Greptile Overview

Greptile Summary

Updated lifespan test fixtures to use session scope, enabling tests to run in both dev and prod environments via the app_harness_env fixture

Key Changes:

• Modified AppHarness return type annotations from explicit class names to Self for better subclass type compatibility
• Changed test fixtures (mount_api_transformer, mount_cached_fastapi, lifespan_app) to scope="session" for efficiency
• Updated lifespan_app fixture to accept app_harness_env parameter, allowing it to test both AppHarness and AppHarnessProd
• Replaced tmp_path with tmp_path_factory to support session-scoped fixtures
• Added explicit app_name parameter to avoid naming conflicts across test variants

Issues Found:

• Self is imported from typing instead of typing_extensions, which will cause import errors on Python 3.10 (project supports Python >=3.10, but Self was only added to typing in Python 3.11)

Confidence Score: 3/5

• This PR has a critical import issue that will break Python 3.10 compatibility
• Score reflects the correct architectural approach and test improvements, but the import of Self from typing instead of typing_extensions will cause runtime errors on Python 3.10, which is still supported by the project
• Pay close attention to reflex/testing.py - the Self import must be fixed before merging

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant Test as test_lifespan
    participant Fixture as lifespan_app fixture
    participant Factory as tmp_path_factory
    participant Env as app_harness_env
    participant AppHarness as AppHarness/AppHarnessProd
    participant App as LifespanApp

    Test->>Fixture: Request lifespan_app (session scope)
    Fixture->>Env: Get harness class (dev or prod)
    Fixture->>Factory: mktemp("lifespan_app")
    Factory-->>Fixture: tmp_path
    Fixture->>AppHarness: create(root, app_source, app_name)
    AppHarness->>AppHarness: _initialize_app()
    AppHarness->>App: Initialize with params
    App-->>AppHarness: Configured app instance
    AppHarness->>AppHarness: start() [returns Self]
    AppHarness-->>Fixture: Running harness
    Fixture-->>Test: Yield harness instance
    Test->>Test: Run test assertions
    Test-->>Fixture: Test complete
    Fixture->>AppHarness: __exit__() cleanup
    AppHarness->>AppHarness: stop()