Remove implicit panics in NotNan<T> x T operators#167
Merged
mbrubeck merged 3 commits intoreem:masterfrom Feb 17, 2025
Merged
Conversation
Ten0
force-pushed
the
less_implicit_panic_on_binary_operations
branch
from
a24e711 to
86f0b79
Compare
mbrubeck
approved these changes
Feb 17, 2025
Collaborator
|
Thanks! I am going to fix #142 as well before publishing this in a new major version of ordered-float. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #166 as discussed there.
Tests that disappear are those that relate to
not_nan += maybe_nanpanicking which now doesn't compile.Apologies for the small amount of extra auto-formatting, please let me know if that is an issue and I'll remove it.