Skip to content

Comments

feat: optionally integrate with num-cmp#155

Merged
mbrubeck merged 1 commit intoreem:masterfrom
tisonkun:num-cmp
Sep 25, 2024
Merged

feat: optionally integrate with num-cmp#155
mbrubeck merged 1 commit intoreem:masterfrom
tisonkun:num-cmp

Conversation

@tisonkun
Copy link
Contributor

This closes #154.

@tisonkun
Copy link
Contributor Author

But to implement impl<T, U> NumCmp<OrderedFloat<T>> for U the other side conflicts. Perhaps we should do on the upstream anyway. However, the upstream isn't updated over 7 years ...

Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrubeck mbrubeck merged commit 20d8033 into reem:master Sep 25, 2024
@tisonkun tisonkun deleted the num-cmp branch September 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement NumCmp for OrderedFloat as if f32/f64

2 participants