Add lossy conversion for NotNan<f64> to NotNan<f32>#109
Merged
mbrubeck merged 2 commits intoreem:masterfrom Apr 30, 2022
MultisampledNight:add-f64-f32-conversion
Merged
Add lossy conversion for NotNan<f64> to NotNan<f32>#109mbrubeck merged 2 commits intoreem:masterfrom MultisampledNight:add-f64-f32-conversion
NotNan<f64> to NotNan<f32>#109mbrubeck merged 2 commits intoreem:masterfrom
MultisampledNight:add-f64-f32-conversion
Conversation
Collaborator
|
Thanks! For naming, I think a shorter name like |
Contributor
Author
|
Thank you for the consideration! I changed the name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it's not cleanly possible to convert a
NotNan<f64>to aNotNan<f32>if you're aware of the precision loss and are ready to take it without unwrapping and re-wrapping again.So this PR addresses this through adding a
NotNan::<f64>::into_notnan_f64_lossywhich does that automatically.I'm not sure about the naming of the method. I'd like to shorten it, and also I'm not sure whether that's a case for using
as_naming, as the Rust API guidelines suggest.