-
Notifications
You must be signed in to change notification settings - Fork 80
Comparing changes
Open a pull request
base repository: reem/rust-ordered-float
base: v4.3.0
head repository: reem/rust-ordered-float
compare: v4.4.0
- 10 commits
- 5 files changed
- 3 contributors
Commits on Oct 15, 2024
-
Document that
NotNanisrepr(transparent).Currently, rustdoc only displays `repr(transparent)` if the type’s fields are public, so there is no indication in the documentation that `NotNan` has `repr(transparent)`. Even if it was visible, there is not currently a strong consensus that such a repr may be assumed to be a stable part of the public API. Therefore, add paragraphs to `NotNan` and `OrderedFloat`’s documentation guaranteeing the repr. I also mentioned `bytemuck` so as to not be encouraging unsafe code, though the phrasing isn’t great.
Configuration menu - View commit details
-
Copy full SHA for 4b07101 - Browse repository at this point
Copy the full SHA 4b07101View commit details -
Add
impl bytemuck::TransparentWrapper for OrderedFloat.This gives a more strongly-typed way for users to take advantage of `OrderedFloat`’s representation.
Configuration menu - View commit details
-
Copy full SHA for 7abdbc9 - Browse repository at this point
Copy the full SHA 7abdbc9View commit details -
Merge pull request #158 from kpreid/transparent
Document that `NotNan` is `repr(transparent)`.
Configuration menu - View commit details
-
Copy full SHA for e2c7a82 - Browse repository at this point
Copy the full SHA e2c7a82View commit details -
Also remove a stray blank line that showed up in the documentation.
Configuration menu - View commit details
-
Copy full SHA for 85a4b9d - Browse repository at this point
Copy the full SHA 85a4b9dView commit details -
CI: update actions/checkout, remove actions-rs/*
This should fix all deprecation warnings from GitHub Actions. actions-rs/toolchain and actions-rs/cargo are both unmaintained, but they can largely be replaced with plain `rustup` and `cargo` commands, except for the problem matchers.
Configuration menu - View commit details
-
Copy full SHA for d614112 - Browse repository at this point
Copy the full SHA d614112View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88275c3 - Browse repository at this point
Copy the full SHA 88275c3View commit details -
Merge pull request #160 from kpreid/ci
CI: update actions/checkout, remove actions-rs/*
Configuration menu - View commit details
-
Copy full SHA for 6c47902 - Browse repository at this point
Copy the full SHA 6c47902View commit details
Commits on Oct 16, 2024
-
feat: integrate with derive-visitor
Signed-off-by: tison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e7da65 - Browse repository at this point
Copy the full SHA 0e7da65View commit details -
Merge pull request #161 from tisonkun/derive-visitor
feat: integrate with derive-visitor
Configuration menu - View commit details
-
Copy full SHA for dc0269e - Browse repository at this point
Copy the full SHA dc0269eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 324b3e1 - Browse repository at this point
Copy the full SHA 324b3e1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.3.0...v4.4.0