Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: reem/rust-ordered-float
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.3.0
Choose a base ref
...
head repository: reem/rust-ordered-float
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.0
Choose a head ref
  • 10 commits
  • 5 files changed
  • 3 contributors

Commits on Oct 15, 2024

  1. Document that NotNan is repr(transparent).

    Currently, rustdoc only displays `repr(transparent)` if the type’s
    fields are public, so there is no indication in the documentation that
    `NotNan` has `repr(transparent)`. Even if it was visible, there is not
    currently a strong consensus that such a repr may be assumed to be a
    stable part of the public API.
    
    Therefore, add paragraphs to `NotNan` and `OrderedFloat`’s documentation
    guaranteeing the repr. I also mentioned `bytemuck` so as to not be
    encouraging unsafe code, though the phrasing isn’t great.
    kpreid committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4b07101 View commit details
    Browse the repository at this point in the history
  2. Add impl bytemuck::TransparentWrapper for OrderedFloat.

    This gives a more strongly-typed way for users to take advantage of
    `OrderedFloat`’s representation.
    kpreid committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7abdbc9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #158 from kpreid/transparent

    Document that `NotNan` is `repr(transparent)`.
    mbrubeck authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e2c7a82 View commit details
    Browse the repository at this point in the history
  4. Document signed zero hazards.

    Also remove a stray blank line that showed up in the documentation.
    kpreid committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    85a4b9d View commit details
    Browse the repository at this point in the history
  5. CI: update actions/checkout, remove actions-rs/*

    This should fix all deprecation warnings from GitHub Actions.
    
    actions-rs/toolchain and actions-rs/cargo are both unmaintained, but
    they can largely be replaced with plain `rustup` and `cargo` commands,
    except for the problem matchers.
    kpreid committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d614112 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #159 from kpreid/eq

    Document signed zero hazards.
    mbrubeck authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    88275c3 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #160 from kpreid/ci

    CI: update actions/checkout, remove actions-rs/*
    mbrubeck authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6c47902 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. feat: integrate with derive-visitor

    Signed-off-by: tison <[email protected]>
    tisonkun committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0e7da65 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #161 from tisonkun/derive-visitor

    feat: integrate with derive-visitor
    mbrubeck authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dc0269e View commit details
    Browse the repository at this point in the history
  3. Version 4.4.0

    mbrubeck committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    324b3e1 View commit details
    Browse the repository at this point in the history
Loading