Closed
Conversation
jtoar
changed the title
Tobbe
reviewed
Jan 21, 2024
| `cd ${path.relative(process.cwd(), newAppDir)}` | ||
| )}` | ||
| )}`, | ||
| !yarnInstall && |
Contributor
There was a problem hiding this comment.
I think the logic is flipped here. We should always include the instruction to run yarn install now, right?
(Hold changing anything, I'm still reviewing)
Contributor
Author
There was a problem hiding this comment.
Yep you're right I think oversight on my part in making this too fast
| Fire it up! 🚀 | ||
|
|
||
| > cd redwood-app | ||
| > yarn install |
Contributor
There was a problem hiding this comment.
I think this change should be reverted
Contributor
|
Closing this in favor of #9861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tobbe told me he couldn't run
yarn create redwood-appwith yarn v1. I was able to reproduce and so was @Josh-Walker-GM:I'm not sure if this is new as of yarn v4 or not, but I think it's time we removed the yarn install preference in CRWA; I brought it up before in #9786 (comment) but we held off at the time.
@Tobbe I'm happy to cherry pick this into the next branch and release a patch.