fix(fastify): Server not handling periods in query params#9714
Merged
jtoar merged 5 commits intoredwoodjs:mainfrom Dec 19, 2023
Merged
Conversation
Contributor
|
Thanks a lot for your PR @hawkk9 🙂 Could you please take a look at the automatic review comments you got and try to fix that warning? Thanks! |
Contributor
Author
|
@Tobbe |
Contributor
|
Thanks @hawkk9 I should have asked this too in my original comment, but would it be possible to add some tests for this? I'm not super familiar with this code. Some tests would make me feel more comfortable merging this. |
Contributor
Author
Tobbe
pushed a commit
that referenced
this pull request
Dec 21, 2023
Fix for this issue. #9663 If the query parameter contains`. `will result in a 404 error when routing to the defined route. Example.) http://localhost:8910/posts?redirect_url=https%3A%2F%2Fwww.google.com - Version: 6.3.3 or higher - When the application is running with `yarn rw serve` command. - Version: 6.3.2 or lower - When the application is running with `yarn rw dev` command. --------- Co-authored-by: yuichi.nishitani <[email protected]> Co-authored-by: Dominic Saadi <[email protected]>
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for this issue.
#9663
If the query parameter contains
.will result in a 404 error when routing to the defined route.Example.)
http://localhost:8910/posts?redirect_url=https%3A%2F%2Fwww.google.com
The problem occurs
yarn rw servecommand.The problem not occurs
yarn rw devcommand.