#9620: Update studio to support variable components (Mailer)#9639
Merged
Josh-Walker-GM merged 9 commits intoredwoodjs:mainfrom Dec 24, 2023
Merged
Conversation
1 task
raph90
force-pushed
the
9620_mailer_not_recognising_templates
branch
from
01dbed4 to
6e51aaf
Compare
Contributor
|
@raph90 Thanks for your PR. Looks like you need to run |
raph90
force-pushed
the
9620_mailer_not_recognising_templates
branch
from
6e51aaf to
750240f
Compare
Contributor
Author
Tobbe
reviewed
Dec 8, 2023
Tobbe
reviewed
Dec 8, 2023
Contributor
Author
|
Updated based on your comments @Tobbe |
Contributor
|
@Josh-Walker-GM I'll leave the final review to you |
Josh-Walker-GM
suggested changes
Dec 13, 2023
Contributor
Josh-Walker-GM
left a comment
Josh-Walker-GM
left a comment
There was a problem hiding this comment.
I think there a small thing to correct in the AST processing which I've commented explicitly about. Otherwise I'm happy with this and we can get it merge once that's addressed. Thanks!
raph90
force-pushed
the
9620_mailer_not_recognising_templates
branch
from
0bd0e01 to
e3a79e5
Compare
raph90
force-pushed
the
9620_mailer_not_recognising_templates
branch
from
e3a79e5 to
648f4df
Compare
Josh-Walker-GM
approved these changes
Dec 23, 2023
Contributor
Josh-Walker-GM
left a comment
Josh-Walker-GM
left a comment
There was a problem hiding this comment.
@raph90 I pushed up some changes - I hope you don't mind. By changing the way swc was imported it now is typed so that made things easier to work with.
Would you be able to test this out and confirm everything is now working as you'd expect? After that I'll merge.
Contributor
Author
|
All looking good to me @Josh-Walker-GM! Weirdly I am still getting the error, but when I actually go into studio and look at the templates everything is working. It might be because the project I'm testing on is running Redwood 6.0.7 rather than canary, I'm not sure. But I think this is good to go if you're happy! |
Josh-Walker-GM
added a commit
that referenced
this pull request
Dec 24, 2023
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Dec 27, 2023
…redwood into fix/enhance-error-apollo-suspense * 'fix/enhance-error-apollo-suspense' of github.com:dac09/redwood: (92 commits) chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759) Make it easier to find useMatch docs (redwoodjs#9756) chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754) fix(context): Refactor context (redwoodjs#9371) docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749) add TS support for storybook preview tsx config extension (redwoodjs#9309) fix(studio): Fix windows path issues (redwoodjs#9752) redwoodjs#9620: Update studio to support variable components (Mailer) (redwoodjs#9639) chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751) chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746) chore(tooling): Make sure console boxen print on a new line chore(CI): fix publish release candidate feat(CLI): add check node version middleware, rm `.nvmrc`, yarn engines (redwoodjs#9728) docs: added some clarification on serverless functions getting executed in a non-serverless environment (redwoodjs#9742) Fix sshExec() errors not displaying (redwoodjs#9743) chore(tooling): Add missing word in release tooling output Update Metadata docs (redwoodjs#9744) chore(CI): update test project fixture and CRWA for deploy target CI repo (redwoodjs#9730) chore(tooling): add script for getting nested dependency data (redwoodjs#9734) Trusted Documents docs: Proofreading corrections (redwoodjs#9737) ...
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Dec 27, 2023
…ath-aliases * 'main' of github.com:redwoodjs/redwood: (92 commits) chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759) Make it easier to find useMatch docs (redwoodjs#9756) chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754) fix(context): Refactor context (redwoodjs#9371) docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749) add TS support for storybook preview tsx config extension (redwoodjs#9309) fix(studio): Fix windows path issues (redwoodjs#9752) redwoodjs#9620: Update studio to support variable components (Mailer) (redwoodjs#9639) chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751) chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746) chore(tooling): Make sure console boxen print on a new line chore(CI): fix publish release candidate feat(CLI): add check node version middleware, rm `.nvmrc`, yarn engines (redwoodjs#9728) docs: added some clarification on serverless functions getting executed in a non-serverless environment (redwoodjs#9742) Fix sshExec() errors not displaying (redwoodjs#9743) chore(tooling): Add missing word in release tooling output Update Metadata docs (redwoodjs#9744) chore(CI): update test project fixture and CRWA for deploy target CI repo (redwoodjs#9730) chore(tooling): add script for getting nested dependency data (redwoodjs#9734) Trusted Documents docs: Proofreading corrections (redwoodjs#9737) ...
Tobbe
pushed a commit
that referenced
this pull request
Jan 1, 2024
Reference to #9620. Currently Studio supports `export function Welcome()` syntax for emails. This PR adds support for `export const Welcome = () => ...` Also added optional dependencies for SWC to fix an error that _I think_ is architecture related. --------- Co-authored-by: Josh GM Walker <[email protected]>
Tobbe
pushed a commit
that referenced
this pull request
Jan 1, 2024
Tobbe
pushed a commit
that referenced
this pull request
Jan 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to #9620.
Currently Studio supports
export function Welcome()syntax for emails. This PR adds support forexport const Welcome = () => ...Also added optional dependencies for SWC to fix an error that I think is architecture related.