fix(router): Fix inheritance of private props in nested sets #9306
Closed
dac09 wants to merge 5 commits intoredwoodjs:mainfrom
Closed
fix(router): Fix inheritance of private props in nested sets #9306dac09 wants to merge 5 commits intoredwoodjs:mainfrom
dac09 wants to merge 5 commits intoredwoodjs:mainfrom
Conversation
to make reading and refactoring easer
Tobbe
added a commit
to Tobbe/redwood
that referenced
this pull request
Oct 17, 2023
Contributor
|
This issue is already fixed in #9303 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in https://community.redwoodjs.com/t/private-route-error-with-7-0-0-canary-347/5337
Tldr;
When you nest
<Private>or<Set private>under another one, we assume the child Set is private also. BUT we had extra logic to check that unauthenticated was also set on any private set. This PR makes sure that the unauthenticated is passed down from the parent set, but also can be overriden in the current Set.See the test for more details - it's hard to describe!