<PrivateSet>#9303
Merged
Tobbe merged 12 commits intoredwoodjs:mainfrom Oct 18, 2023
Merged
Conversation
Tobbe
force-pushed
the
tobbe-privateset
branch
from
021994d to
211f576
Compare
Tobbe
added
release:fix
dac09
reviewed
Oct 17, 2023
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Oct 19, 2023
…redwood into fix/fe-server-dont-always-timeout * 'fix/fe-server-dont-always-timeout' of github.com:dac09/redwood: `<PrivateSet>` (redwoodjs#9303)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate the
<Private>component and theprivateprop on<Set>. Instead we introduce a new<PrivateSet>component.This PR should be fully backwards compatible.
Fully removing
<Private>andprivatewill be done in RW v7 (or later major version)See also: #9271
Fixes #2562
Fixes #9304
Also fixes the issue addressed by #9306