fix(v6, serverless): use named exports instead of default#8857
Merged
Conversation
1 task
jtoar
added a commit
that referenced
this pull request
Jul 9, 2023
The packing/nft helper kind of mixes named exports with default exports and it ends up confusing build tools. It looks like we want named exports, so I just refactored it to that. This was causing `yarn rw deploy serverless --pack-only` to fail in deploy target CI (see https://github.com/redwoodjs/deploy-target-ci/actions/runs/5482609165/jobs/9988107090). Bug was introduced in #8456.
jtoar
added a commit
that referenced
this pull request
Jul 9, 2023
The packing/nft helper kind of mixes named exports with default exports and it ends up confusing build tools. It looks like we want named exports, so I just refactored it to that. This was causing `yarn rw deploy serverless --pack-only` to fail in deploy target CI (see https://github.com/redwoodjs/deploy-target-ci/actions/runs/5482609165/jobs/9988107090). Bug was introduced in #8456.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packing/nft helper kind of mixes named exports with default exports and it ends up confusing build tools. It looks like we want named exports, so I just refactored it to that. This was causing
yarn rw deploy serverless --pack-onlyto fail in deploy target CI (see https://github.com/redwoodjs/deploy-target-ci/actions/runs/5482609165/jobs/9988107090). Bug was introduced in #8456.