Merged
Conversation
jtoar
commented
May 8, 2023
Comment on lines
-7
to
-10
| > **Prerequisites** | ||
| > | ||
| > - Redwood requires [Node.js](https://nodejs.org/en/) (>=16.19 <=18.x) and [Yarn](https://yarnpkg.com/) (>=1.15) | ||
| > - Are you on Windows? For best results, follow our [Windows development setup](how-to/windows-development-setup.md) guide |
Contributor
Author
Contributor
There was a problem hiding this comment.
Now that you pointed it out, I can't stop thinking "gross" 🤢
Good call. Doesn't need to be a part of this PR, to be clear.
Contributor
Author
There was a problem hiding this comment.
@thedavidprice this was a Rachel Nabors tip!
| @@ -621,44 +652,6 @@ async function createRedwoodApp() { | |||
| 'Get up and running fast with this Quick Start guide' | |||
| )}: https://redwoodjs.com/docs/quick-start`, | |||
Contributor
There was a problem hiding this comment.
What do you think about making this https://redwoodjs.com/quick-start and adding a redirect? I can take care of that if you want.
Contributor
Author
There was a problem hiding this comment.
Makes sense. Happy to change it here and just confirm the redirect's going before release
jtoar
added a commit
that referenced
this pull request
May 9, 2023
* remove extraneous links * handle yarn 1 vs yarn 3 * avoid lint warnings * update telemetry ci * update quick start * continue updating quick start * do install before cli * try cd and install * try cwd with path join * import path * move enable immutable installs * backport quick start changes * fix yarn install description * rm needless type hint * consistent spelling in output * copy tweaks * console relative path * change quick start link * tone down warning since user deliberately declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Kind of fixes #8164 by avoiding the problem: this PR disables the
--yarn-installflag and prompting if the package manager is yarn berry. Just came up with this solution after talking to @thedavidprice.The rationale here is simply that we'd rather provide a working experience than one with caveats. It's easy enough to
cdinto the new directory and runyarn install(which works because of the'node-modules'nodeLinkerconfigured in.yarnrc.yml). Other create experiences like vite (who to my knowledge would also suffer from the same bug) simply instruct the user tocdandyarn installbefore starting too.We can add back the
--yarn-installflag for yarn berry if the issues linked to in #8164 get fixed or we have the bandwidth to implement hackier solutions.yarn 1
yarn 3