Skip to content

Revert "chore(build): Avoid prebuilding api side, instead use an esbuild plugin"#8056

Merged
jtoar merged 3 commits intomainfrom
ds-try-reverting-esbuild-change
Apr 19, 2023
Merged

Revert "chore(build): Avoid prebuilding api side, instead use an esbuild plugin"#8056
jtoar merged 3 commits intomainfrom
ds-try-reverting-esbuild-change

Conversation

@jtoar
Copy link
Copy Markdown
Contributor

@jtoar jtoar commented Apr 18, 2023 •
edited
Loading

This reverts commit af7a998 per the core team meeting. The tutorial e2e in CI has been failing consistently on all PRs for a bit now. Even though the changes in this commit seem to have no relation, reverting it seems to fix things, so while I'm not sure what's up, we decided in the best interest to revert this for now so we can merge things. After reverting, I'll open another PR with the changes in the commit and we'll merge it again as soon as we figure out why CI is failing.

@replay-io
Copy link
Copy Markdown

replay-io Bot commented Apr 18, 2023 •
edited
Loading

15 replays were recorded for 5c8a437.

image 0 Failed
image 15 Passed

View test run on Replay ↗︎

@replay-io
Copy link
Copy Markdown

replay-io Bot commented Apr 18, 2023

16 replays were recorded for ba78153.

image 0 Failed
image 16 Passed
    requireAuth graphql checks 
          ```
    locator.waitFor: Target closed
    =========================== logs ===========================
    waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
    ============================================================
    ```
  </ol>
</details>
<li><a href=https://app.replay.io/recording/42638e45-8039-4070-8909-ac549fba101b>useAuth hook, auth redirects checks</a></li>
<li><a href=https://app.replay.io/recording/5ef8b15c-b178-42b9-9318-2a8f4371df3c>Check that a specific blog post is prerendered</a></li>
<li><a href=https://app.replay.io/recording/7dd3390d-c042-44eb-9ead-eaf96e6c7fff>Check that about is prerendered</a></li>
<li><a href=https://app.replay.io/recording/ce20aa4c-5e71-482a-88ef-c6a8221a84f2>Check that homepage is prerendered</a></li>
<li><a href=https://app.replay.io/recording/39185a7e-056c-497e-939b-62cecb64f9b6>Check that meta-tags are rendering the correct dynamic data</a></li>
<li><a href=https://app.replay.io/recording/e563ca38-1e18-4290-8456-c4de66bf46dd>Check that you can navigate from home page to specific blog post</a></li>
<li><a href=https://app.replay.io/recording/def8554c-cbea-4ef1-bf16-d45b0b3bf167>Waterfall prerendering (nested cells)</a></li>
<li><a href=https://app.replay.io/recording/ac30e141-4e59-407e-b8a2-b9e2f08b3065>RBAC: Admin user should be able to delete contacts</a></li>
<li><a href=https://app.replay.io/recording/b59566fb-a46d-4b17-abd6-603b52f82a90>RBAC: Should not be able to delete contact as non-admin user</a></li>
<li><a href=https://app.replay.io/recording/1163771e-6364-456d-8a6a-2d8470e84024>Smoke test with dev server</a></li>
<li><a href=https://app.replay.io/recording/1ee0de38-1091-45c2-aae2-bd8e964e1e1b>Smoke test with rw serve</a></li>
<li><a href=https://app.replay.io/recording/c2b4f44f-bb5d-4707-9c93-562b41d20fd6>Loads Cell mocks when Cell is nested in another story</a></li>
<li><a href=https://app.replay.io/recording/b94e192f-7ce2-43bd-9591-7cfea742f2d9>Loads Cell Stories</a></li>
<li><a href=https://app.replay.io/recording/df5ad44f-b65c-44bf-b7b7-727372951b4e>Loads MDX Stories</a></li>
<li><a href=https://app.replay.io/recording/056302f2-8258-4a2a-ae19-aba633ac3640>Mocks current user, and updates UI while dev server is running</a></li>

View test run on Replay ↗︎

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Apr 19, 2023
@jtoar jtoar marked this pull request as ready for review April 19, 2023 18:02
@jtoar jtoar merged commit e9d63f6 into main Apr 19, 2023
@jtoar jtoar deleted the ds-try-reverting-esbuild-change branch April 19, 2023 19:00
@redwoodjs-bot redwoodjs-bot Bot added this to the next-release milestone Apr 19, 2023
jtoar added a commit that referenced this pull request Apr 20, 2023
@jtoar
Revert "Revert "chore(build): Avoid prebuilding api side, instead use…
7f451fa 
… an esbuild plugin" (#8056)"

This reverts commit e9d63f6.
@jtoar jtoar modified the milestones: next-release, v5.0.0, chore Apr 27, 2023
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release:chore This PR is a chore (means nothing for users)

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jtoar @Josh-Walker-GM