Skip to content

chore(ci): Update node version for telemetry check#8004

Merged
Josh-Walker-GM merged 2 commits intomainfrom
jmgw-ci-telemetry-node-version
Apr 4, 2023
Merged

chore(ci): Update node version for telemetry check#8004
Josh-Walker-GM merged 2 commits intomainfrom
jmgw-ci-telemetry-node-version

Conversation

@Josh-Walker-GM
Copy link
Copy Markdown
Contributor

@Josh-Walker-GM Josh-Walker-GM commented Apr 3, 2023 •
edited
Loading

Problem
After updating the engine check requirements to a minimum of 16.20 the GitHub ci node version is too low for telemetry checks to run as intended.

Changes
Update from 16 to 16.20.0 in the node version.

@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label Apr 3, 2023
@Josh-Walker-GM Josh-Walker-GM self-assigned this Apr 3, 2023
@replay-io
Copy link
Copy Markdown

replay-io Bot commented Apr 3, 2023 •
edited
Loading

16 replays were recorded for e665451.

image 0 Failed
image 16 Passed
    requireAuth graphql checks 
          ```
    locator.waitFor: Target closed
    =========================== logs ===========================
    waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
    ============================================================
    ```
  </ol>
</details>
<li><a href=https://app.replay.io/recording/c70396ba-bbf1-42d4-8307-b7edf7bb64e0>useAuth hook, auth redirects checks</a></li>
<li><a href=https://app.replay.io/recording/5c2c1f9c-9b6b-43e4-92a2-71db8d9d9855>Check that a specific blog post is prerendered</a></li>
<li><a href=https://app.replay.io/recording/f01ff399-1824-4124-8356-04b51d77ee7e>Check that about is prerendered</a></li>
<li><a href=https://app.replay.io/recording/f536ee08-55fa-43aa-a335-235dc735b574>Check that homepage is prerendered</a></li>
<li><a href=https://app.replay.io/recording/633a69a4-c8cd-41a3-a2c3-96dcf6e3ea98>Check that meta-tags are rendering the correct dynamic data</a></li>
<li><a href=https://app.replay.io/recording/ecb01d02-361e-480a-969d-85a6f2c1d029>Check that you can navigate from home page to specific blog post</a></li>
<li><a href=https://app.replay.io/recording/523ff4f3-e855-40ce-b952-48c2b3629f9c>Waterfall prerendering (nested cells)</a></li>
<li><a href=https://app.replay.io/recording/469e1cf0-2b38-4441-81ac-9b7b98ab7426>RBAC: Admin user should be able to delete contacts</a></li>
<li><a href=https://app.replay.io/recording/19ea9cb8-0a1c-434a-a017-5dfba2e609b2>RBAC: Should not be able to delete contact as non-admin user</a></li>
<li><a href=https://app.replay.io/recording/fbce073e-799a-4a86-b41e-8b57ef751abb>Smoke test with dev server</a></li>
<li><a href=https://app.replay.io/recording/d0f02563-aadf-490d-83d5-093376b488bf>Smoke test with rw serve</a></li>
<li><a href=https://app.replay.io/recording/41cef677-2165-4493-ae01-d65e9d0e6831>Loads Cell mocks when Cell is nested in another story</a></li>
<li><a href=https://app.replay.io/recording/0a41c5bd-bf0a-476d-b63f-418410aca8aa>Loads Cell Stories</a></li>
<li><a href=https://app.replay.io/recording/8e27a50f-1c7b-44ca-9aa1-78fd6a32e001>Loads MDX Stories</a></li>
<li><a href=https://app.replay.io/recording/36868b35-87ae-4ada-b3e8-37f147675bd8>Mocks current user, and updates UI while dev server is running</a></li>

View test run on Replay ↗︎

@Josh-Walker-GM
Copy link
Copy Markdown
Contributor Author

Josh-Walker-GM commented Apr 3, 2023

I'm going to enable auto-merge on this without an additional approval given how minor the change is and that it'll be blocking CI on all other PRs until this is corrected.

@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) April 3, 2023 23:51
jtoar
jtoar approved these changes Apr 4, 2023
View reviewed changes
Comment thread .github/workflows/ci.yml
matrix:
os: [ubuntu-latest, windows-latest]
node-version: [16, 18]
node-version: [16.20.0, 18]
Copy link
Copy Markdown
Contributor

@jtoar jtoar Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a miss on actions/setup-node's part. Not sure why 16 doesn't pull down the latest.

Just checked their docs—we could set the "check-latest" option to true:

Suggested change
node-version: [16.20.0, 18]
node-version: [16, 18]
check-latest: true

https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#check-latest-version

But maybe it's better to be more exact like you have it here since we support a minimum 16 version? I'll leave it up to you! If we go with 16.20.0 I'll have to change the settings to accept a check passing with that title, which is no big deal. Docs for reference:

https://github.com/redwoodjs/redwood/blob/385064dbc5a8c775e69a837277722a5509ef21ca/packages/create-redwood-app/template/package.json#L17

Copy link
Copy Markdown
Contributor

@jtoar jtoar Apr 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the required check's name for now

@Josh-Walker-GM Josh-Walker-GM merged commit e3c8dbf into main Apr 4, 2023
@Josh-Walker-GM Josh-Walker-GM deleted the jmgw-ci-telemetry-node-version branch April 4, 2023 01:27
@redwoodjs-bot redwoodjs-bot Bot added this to the next-release milestone Apr 4, 2023
@jtoar jtoar modified the milestones: next-release, v4.5.0 Apr 5, 2023
jaiakt pushed a commit to jaiakt/redwood that referenced this pull request Apr 5, 2023
@Josh-Walker-GM @jaiakt
chore(ci): Update node version for telemetry check (redwoodjs#8004)
707c01f 
* Update ci.yml

* Update ci.yml
dac09 added a commit to dac09/redwood that referenced this pull request Apr 6, 2023
@dac09
Merge branch 'feat/vite-ssr' of github.com:dac09/redwood into feat/vi…
c2e6c8b 
…te-ssr

* 'feat/vite-ssr' of github.com:dac09/redwood:
  chore(build): Avoid prebuilding api side, instead use an esbuild plugin (redwoodjs#7672)
  chore(deps): update dependency @clerk/clerk-react to v4.14.2 (redwoodjs#8016)
  chore(deps): update dependency @azure/msal-browser to v2.35.0 (redwoodjs#8009)
  chore(deps): update dependency @supabase/supabase-js to v2.14.0 (redwoodjs#8010)
  fix(deps): update typescript-eslint monorepo to v5.57.1 (redwoodjs#8008)
  fix(deps): update dependency core-js to v3.30.0 (redwoodjs#8007)
  chore(deps): update dependency @playwright/test to v1.32.2 (redwoodjs#8005)
  fix(deps): update dependency @fastify/static to v6.10.0 (redwoodjs#7999)
  chore(deps): update dependency dependency-cruiser to v12.11.1 (redwoodjs#7998)
  Update docs to reference creating an ED25519 key instead of RSA (redwoodjs#8013)
  chore(deps): update dependency @types/react to v18.0.33 (redwoodjs#7996)
  chore(deps): update dependency @replayio/playwright to v0.3.28 (redwoodjs#8006)
  chore(deps): update dependency esbuild to v0.17.15 (redwoodjs#7994)
  chore(deps): update mheap/github-action-required-labels action to v4 (redwoodjs#7997)
  chore(ci): Update node version for telemetry check (redwoodjs#8004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jtoar jtoar jtoar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Josh-Walker-GM Josh-Walker-GM

Labels

release:chore This PR is a chore (means nothing for users)

Projects

None yet

Milestone

v4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Josh-Walker-GM @jtoar