Convert layout generator to TypeScript#685
Convert layout generator to TypeScript#685peterp merged 14 commits intoredwoodjs:mainfrom kimadeline:convert-layout-ts
Conversation
| @@ -1,4 +1,4 @@ | |||
| const ${pascalName} = () => { | |||
| const ${pascalName}: React.FunctionComponent = () => { | |||
There was a problem hiding this comment.
Do we want to proactively type generated components, in case people want to use FC props like children?
|
@kimadeline Thanks again!
^^ Looping in @peterp. See the TS gif example above. The Here's a screenshot of the error. Possibly a TS issue with the testing package itself? |
|
@kimadeline Thanks for this! |
|
Confirming I checked the output and there's no change from previous. So Tutorial check == ✅ @peterp when you loop back to this, wanted to make sure you saw my question above (which was in response to @kimadeline's original question) ^^ |
|
@thedavidprice I could not see the original question? So I'm wondering if it's still relevant @kimadeline? |
|
@peterp Ah, that could be the case. If I recall correctly, is the testing package now supporting TS (and wasn't before)? |
|
Sweet! Hopefully that solved it, we're going to release |

For #523
🎩 Ported the layout generator to TypeScript:
Default (JS):
JS:
TS (any idea on what I need to do to make the squiggles under
renderdisappear? #689?):🚮 Cleaned up some of the unnecessary stuff I introduced when I ported the component generator.