Thanks for the update @flybayer 👍🏻 should be merged in no time.

@jtoar just wanted to double check on this one, I added the fixture-ok label, is this indeed the correct move for our case?
I'm rolling back on my approval because of this only.

@noire-munich Yes, fixture-ok is the right choice. Our test project doesn't use this file and isn't affected by this change in any way.

If you're unsure it's always okay to just rebuild the test project fixture and commit the changes. That label is just a quick way around having to do that if you know it's not really needed

Thanks @Tobbe ! This confirms how I thought about it, it's good to know 👍

Thanks @noire-munich! Yeah let's get this merged so we can hand it off to the deploy target CI repo.

14 replays were recorded for c7e1b70.

0 Failed

14 Passed

• Loads Cell Stories
• Smoke test with dev server
• Loads Cell mocks when Cell is nested in another story
• Mocks current user, and updates UI while dev server is running
• useAuth hook, auth redirects checks
• useAuth hook, auth redirects checks
• RBAC: Should not be able to delete contact as non-admin user
• requireAuth graphql checks
• RBAC: Should not be able to delete contact as non-admin user
• RBAC: Should not be able to delete contact as non-admin user
• RBAC: Should not be able to delete contact as non-admin user
• RBAC: Admin user should be able to delete contacts
• Smoke test with rw serve
• Loads MDX Stories

View test run on Replay ↗︎