fix(deploy): added windows fix for nodeFileTrace when deploying to serverless#6325
Merged
dac09 merged 8 commits intoredwoodjs:mainfrom Sep 5, 2022
Merged
Conversation
Tobbe
reviewed
Aug 30, 2022
Tobbe
reviewed
Aug 30, 2022
unregexed. Co-authored-by: Tobbe Lundberg <[email protected]>
unregexed Co-authored-by: Tobbe Lundberg <[email protected]>
dac09
suggested changes
Aug 31, 2022
Contributor
dac09
left a comment
dac09
left a comment
There was a problem hiding this comment.
Leaving a couple of small comments, thank you for your help with this!
IThinkThatsKirby
requested review from
Tobbe and
dac09
and removed request for
Tobbe and
dac09
Contributor
|
Thank you @IThinkThatsKirby - I'll add some more unit tests for this, but looking promising! |
dac09
approved these changes
Sep 5, 2022
Contributor
There was a problem hiding this comment.
All looking good! Thank you so much for your help with this @IThinkThatsKirby
PS I'm very pleased with my kitten utils tests 🤣
dac09
changed the title
1 task
jtoar
pushed a commit
that referenced
this pull request
Sep 8, 2022
* issue#5852 added windows fix for nodeFileTrace * Update packages/internal/src/build/api.ts unregexed. Co-authored-by: Tobbe Lundberg <[email protected]> * Update packages/internal/src/build/web.ts unregexed Co-authored-by: Tobbe Lundberg <[email protected]> * issue# 5852 now only the import files are changed. * issue #5852 only import files changed. * Adds test for src-alias plugin - unlikely to work on Windows Co-authored-by: Tobbe Lundberg <[email protected]> Co-authored-by: Daniel Choudhury <[email protected]>
jtoar
pushed a commit
that referenced
this pull request
Sep 8, 2022
* issue#5852 added windows fix for nodeFileTrace * Update packages/internal/src/build/api.ts unregexed. Co-authored-by: Tobbe Lundberg <[email protected]> * Update packages/internal/src/build/web.ts unregexed Co-authored-by: Tobbe Lundberg <[email protected]> * issue# 5852 now only the import files are changed. * issue #5852 only import files changed. * Adds test for src-alias plugin - unlikely to work on Windows Co-authored-by: Tobbe Lundberg <[email protected]> Co-authored-by: Daniel Choudhury <[email protected]>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Sep 9, 2022
* 'main' of github.com:redwoodjs/redwood: fix(deps): update dependency @graphql-yoga/common to v2.12.12 (redwoodjs#6349) fix(test-project): revert @redwoodjs/core to rc Update yarn.lock v2.2.4 bugfix replace slash in tailwind config on windows (redwoodjs#6203) bugfix replace slash in tailwind config on windows (redwoodjs#6203) chore(deps): update dependency @testing-library/dom to v8.17.1 (redwoodjs#6351) Update yarn.lock Use try/catch to access unauthenticated (redwoodjs#6358) issue#5852 added windows fix for nodeFileTrace (redwoodjs#6325) Handle special props `ref` and `key` in path and search params (redwoodjs#5537) Use try/catch to access unauthenticated (redwoodjs#6358) feat(codemod): Add codemod to make relation resolvers partial (redwoodjs#6342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue windows users where having when building. #5852
In short nodeFileTrace could not find needed dependencies on windows because of windows pathing and the way babel handles results.code output when running on windows.