Change handling of crwa/template/.gitignore#2752
Merged
Conversation
dac09
reviewed
Jun 7, 2021
| fs.copySync(templateDir, newAppDir) | ||
| // .gitignore is renamed here to force file inclusion during publishing | ||
| fs.rename( | ||
| path.join(newAppDir, 'gitignore'), |
Contributor
There was a problem hiding this comment.
What do you think of naming it gitignore.templatein the source so its obvious that it wasn't a typo in the filename?
dac09
approved these changes
Jun 7, 2021
Contributor
dac09
left a comment
dac09
left a comment
There was a problem hiding this comment.
Small suggestion, not very important. but LGTM!
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
thedavidprice
added a commit
that referenced
this pull request
Jun 7, 2021
* change handling of crwa/template/.gitignore * change naming to gitignore.template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2749
Although we confirmed the published create-redwood-app package is missing
template/.gitignore, we could not diagnose why it was excluded duringnpm publish. As a workaround/failsafe, this PR:template/.gitignoretotemplate/gitignore