Looks good @LBrian - I was wondering though it people might want:

• an option to ignore the search params and only consider the route (just /route ... ie, route search is null but location.search is not null, but location route and route paths match -- ie, ignore UTMA campaign params)
• a way to specify which params to match (just page and tab, but not utma_campaign)

This would be the case when say, some UTMA or campaign or even timestamp params might be included in a path and thus might not match the target/specified location.

Looks good @LBrian - I was wondering though it people might want:

• an option to ignore the search params and only consider the route (just /route ... ie, route search is null but location.search is not null, but location route and route paths match -- ie, ignore UTMA campaign params)
• a way to specify which params to match (just page and tab, but note utma_campaign)

This would be the case when say, some UTMA or campaign or even timestamp params might be included in a path and thus might not match the target/specified location.

Good callout @dthyresson

• We can ignore search parameters comparison if search is empty as external usage of useMatch can control what to input as route parameter but still good to accept options for useMatch as we can extend more in options in the future
• This is a good suggestion and will be in options as well

@dthyresson Tweaked, useMatch hook now supports 2nd parameter options for advance matching and the same options can be passed by activeMatchOptions via NavLink to do the same.

@LBrian These additions look good and I think give the useMatch much needed flexibility.

I know the RW team likes to review naming, especially with core features like Router so I'd like to get their feedback on:

• ignoreQueryString so that useMatch only matches the path (and the default case also if the location lacks params, right?)
• matchSearchParamKeys so that useMatch will consider the route and any params specified

I also think that perhaps using the utm cases here as the examples and or tests can give some context/clarity to the use case and can use then in the Router docs:

https://ga-dev-tools.appspot.com/campaign-url-builder/

Used for keyword analysis. Use utm_campaign to identify a specific product promotion or strategic campaign.
Example: utm_campaign=spring_sale

One might match /products?utm_campaign=spring_sale and also /products?utm_campaign=winter_sale

@mojombo @peterp could we get your view on the option names:

• ignoreQueryString so that useMatch only matches the path (and the default case also if the location lacks params, right?)
• matchSearchParamKeys so that useMatch will consider the route and any params specified

Thanks.

• ignoreQueryString so that useMatch only matches the path (and the default case also if the location lacks params, right?)

Correct

• matchSearchParamKeys so that useMatch will consider the route and any params specified

Correct

Used for keyword analysis. Use utm_campaign to identify a specific product promotion or strategic campaign.
Example: utm_campaign=spring_sale

One might match /products?utm_campaign=spring_sale and also /products?utm_campaign=winter_sale

Good idea!

@jtoar @dthyresson @Tobbe Ready for review, I will find some time to update docs tomorrow.

Oh one more thing @LBrian - fancy adding the docs for this into https://github.com/redwoodjs/redwood/blob/main/packages/router/README.md#active-links ? This readme gets pulled into redwoodjs.com

Let me know if you're happy to :), otherwise will add to my list.

Great work on this, everyone! And thanks again for your patience with us @LBrian 🚀

Oh one more thing @LBrian - fancy adding the docs for this into https://github.com/redwoodjs/redwood/blob/main/packages/router/README.md#active-links ? This readme gets pulled into redwoodjs.com

Let me know if you're happy to :), otherwise will add to my list.

Yap, I will do that today!

Hi @LBrian were you still available to work on the doc update? No pressure. Just let us know either way.

Hi @LBrian were you still available to work on the doc update? No pressure. Just let us know either way.

Hi @thedavidprice,

I got blocked by some Svelte issue with my project, I should be able to find sometime to do it this weekend, if I am a blocker, please feel free to take over or reassign. 😃

@thedavidprice Updated doc in #3241 cc @dac09