Skip to content

Restore @storybook/addon-a11y#2309

Merged
jtoar merged 3 commits intomainfrom
ds-reenable-a11y-addon
Apr 18, 2021
Merged

Restore @storybook/addon-a11y#2309
jtoar merged 3 commits intomainfrom
ds-reenable-a11y-addon

Conversation

@jtoar
Copy link
Copy Markdown
Contributor

@jtoar jtoar commented Apr 18, 2021

The webpack console errors from axe-core in @storybook/addon-a11y have been fixed (see storybookjs/storybook#14321) so it's ok to re-enable it! Tape showing the working addon lack of console logs: https://s.tape.sh/EnbdxSnj.

@jtoar jtoar added topic/config Babel, Webpack, ESLint, Prettier, etc. topic/storybook topic/a11y labels Apr 18, 2021
@jtoar jtoar self-assigned this Apr 18, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/create-redwood-app-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-api-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-api-server-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-auth-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-cli-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-core-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-dev-server-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-eslint-config-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-eslint-plugin-redwood-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-forms-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-internal-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-prerender-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-router-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-structure-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-testing-0.30.0-6a25134.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2309/redwoodjs-web-0.30.0-6a25134.tgz

Install this PR by running yarn rw upgrade --pr 2309:0.30.0-6a25134

@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 18, 2021



Test summary

11 0 1 0Flakiness 0


Run details

Project RedwoodJS Framework
Status Passed
Commit 848c5a3 ℹ️
Started Apr 18, 2021 4:56 PM
Ended Apr 18, 2021 4:59 PM
Duration 03:12 💡
OS Linux Ubuntu - 20.04
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@dac09 dac09 added this to the next-release milestone Apr 18, 2021
@jtoar jtoar merged commit 0b93201 into main Apr 18, 2021
@jtoar jtoar deleted the ds-reenable-a11y-addon branch April 18, 2021 17:14
dac09 added a commit to dac09/redwood that referenced this pull request Apr 21, 2021
…erve-web

* 'main' of github.com:redwoodjs/redwood: (40 commits)
  Support generating typescript cells and pages | Autodetect ts project (redwoodjs#2279)
  create-redwood-app messages: moved app start commands to end (redwoodjs#2278)
  Add import type to configuration files (redwoodjs#2214)
  Bump @reach/skip-nav from 0.13.2 to 0.15.0 (redwoodjs#2237)
  Adding Setup Deploy Render Command (redwoodjs#2099)
  Disable role linting in Routes (redwoodjs#2318)
  v0.30.1 (redwoodjs#2322)
  teardown should attempt to delete dbName table (redwoodjs#2083)
  Restore @storybook/addon-a11y (redwoodjs#2309)
  fix(auth): Implement automatic token refresh on supported providers (redwoodjs#2277)
  fix(cli): move api-server dep from api to cli (redwoodjs#2307)
  Static typing for cells (redwoodjs#2208)
  Recommended Babel package upgrades (dependabot) (redwoodjs#2255)
  v0.30.0 (redwoodjs#2301)
  upgrade Prisma v2.21.0 (redwoodjs#2273)
  Further improvements to CONTRIBUTING.md (redwoodjs#2261)
  Adds better messages for rwt link | Watcher does not exist on build failure | Only remove node_modules after a succesful framework build (redwoodjs#2269)
  Update named param types in router readme (redwoodjs#2262)
  Bump core-js from 3.6.5 to 3.10.1 (redwoodjs#2243)
  Fix: webpack optimizations for JS (redwoodjs#2235)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic/a11y topic/config Babel, Webpack, ESLint, Prettier, etc. topic/storybook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants