Skip to content

fix(cli): Move api-server dep from api to cli#2307

Merged
dac09 merged 2 commits intoredwoodjs:mainfrom
dac09:fix/api-server-dep-on-cli
Apr 16, 2021
Merged

fix(cli): Move api-server dep from api to cli#2307
dac09 merged 2 commits intoredwoodjs:mainfrom
dac09:fix/api-server-dep-on-cli

Conversation

@dac09
Copy link
Copy Markdown
Contributor

@dac09 dac09 commented Apr 16, 2021

Fixes #2299

What does it do?

  • Moves api-server dependency out of api and into cli
    Why CLI? Because of the yarn rw serve api command. I think I added it to api by mistake

cc @jeliasson

@dac09 dac09 requested a review from Tobbe April 16, 2021 14:35
@dac09 dac09 changed the title Move api-server dep from api to cli fix(cli): Move api-server dep from api to cli Apr 16, 2021
@dac09 dac09 force-pushed the fix/api-server-dep-on-cli branch from a8d0e4d to e735f60 Compare April 16, 2021 14:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/create-redwood-app-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-api-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-api-server-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-auth-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-cli-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-core-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-dev-server-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-eslint-config-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-eslint-plugin-redwood-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-forms-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-internal-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-prerender-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-router-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-structure-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-testing-0.30.0-43021bb.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2307/redwoodjs-web-0.30.0-43021bb.tgz

Install this PR by running yarn rw upgrade --pr 2307:0.30.0-43021bb

@jeliasson
Copy link
Copy Markdown
Contributor

Strange. I tried to bring in the PR build with yarn rw upgrade --pr 2307:0.30.0-e735f60 and got this error;

error An unexpected error occurred: "expected hoisted manifest for \"@redwoodjs/core#mini-css-extract-plugin\""

Instead I manually updated the packages in respective package.json, and now the api build fails instead;
image

@dac09
Copy link
Copy Markdown
Contributor Author

dac09 commented Apr 16, 2021

Yeah I din't quite trust the PR workflow anymore! This happens when core-js gets duplicated in node module e.g. inside web/node_modules

@dac09 dac09 merged commit 89c1310 into redwoodjs:main Apr 16, 2021
@dac09 dac09 deleted the fix/api-server-dep-on-cli branch April 16, 2021 22:49
@thedavidprice thedavidprice added this to the next-release milestone Apr 20, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Apr 21, 2021
…erve-web

* 'main' of github.com:redwoodjs/redwood: (40 commits)
  Support generating typescript cells and pages | Autodetect ts project (redwoodjs#2279)
  create-redwood-app messages: moved app start commands to end (redwoodjs#2278)
  Add import type to configuration files (redwoodjs#2214)
  Bump @reach/skip-nav from 0.13.2 to 0.15.0 (redwoodjs#2237)
  Adding Setup Deploy Render Command (redwoodjs#2099)
  Disable role linting in Routes (redwoodjs#2318)
  v0.30.1 (redwoodjs#2322)
  teardown should attempt to delete dbName table (redwoodjs#2083)
  Restore @storybook/addon-a11y (redwoodjs#2309)
  fix(auth): Implement automatic token refresh on supported providers (redwoodjs#2277)
  fix(cli): move api-server dep from api to cli (redwoodjs#2307)
  Static typing for cells (redwoodjs#2208)
  Recommended Babel package upgrades (dependabot) (redwoodjs#2255)
  v0.30.0 (redwoodjs#2301)
  upgrade Prisma v2.21.0 (redwoodjs#2273)
  Further improvements to CONTRIBUTING.md (redwoodjs#2261)
  Adds better messages for rwt link | Watcher does not exist on build failure | Only remove node_modules after a succesful framework build (redwoodjs#2269)
  Update named param types in router readme (redwoodjs#2262)
  Bump core-js from 3.6.5 to 3.10.1 (redwoodjs#2243)
  Fix: webpack optimizations for JS (redwoodjs#2235)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yarn rw build web requires @redwoodjs/api-server

4 participants