Support generating typescript cells and pages | Autodetect ts project#2279
Merged
dac09 merged 16 commits intoredwoodjs:mainfrom Apr 21, 2021
Merged
Support generating typescript cells and pages | Autodetect ts project#2279dac09 merged 16 commits intoredwoodjs:mainfrom
dac09 merged 16 commits intoredwoodjs:mainfrom
Conversation
dac09
force-pushed
the
feat/ts-generators-cell-pages-layouts
branch
2 times, most recently
from
2b16e2b to
f896c5f
Compare
dac09
commented
Apr 19, 2021
| ]) | ||
| }) | ||
|
|
||
| test.only('includes skip link when --skipLink is set to true', () => { |
dac09
commented
Apr 19, 2021
| agg[k] = v.default | ||
| return agg | ||
| }, {}) | ||
| return Object.entries(builder).reduce( |
Contributor
Author
There was a problem hiding this comment.
Just renames the variables to make it more readable
dthyresson
reviewed
Apr 19, 2021
dac09
force-pushed
the
feat/ts-generators-cell-pages-layouts
branch
from
79d8e07 to
cd386b1
Compare
dac09
force-pushed
the
feat/ts-generators-cell-pages-layouts
branch
from
ff61cea to
cd5bf91
Compare
peterp
approved these changes
Apr 21, 2021
Member
peterp
left a comment
peterp
left a comment
There was a problem hiding this comment.
This is a monster... Thanks for doing this! 🦾, it looks good to me, but I didn't spend as much time as I would've wanted one this, but given the size and the fact that it's all tested makes me feel more confident.
Contributor
Author
|
I'll make sure to test these manually before the release with DT's help, but I was fairly careful - made sure all the tests pass first, then moved them to snapshots, then checked each individual snapshot |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Apr 21, 2021
…erve-web * 'main' of github.com:redwoodjs/redwood: (40 commits) Support generating typescript cells and pages | Autodetect ts project (redwoodjs#2279) create-redwood-app messages: moved app start commands to end (redwoodjs#2278) Add import type to configuration files (redwoodjs#2214) Bump @reach/skip-nav from 0.13.2 to 0.15.0 (redwoodjs#2237) Adding Setup Deploy Render Command (redwoodjs#2099) Disable role linting in Routes (redwoodjs#2318) v0.30.1 (redwoodjs#2322) teardown should attempt to delete dbName table (redwoodjs#2083) Restore @storybook/addon-a11y (redwoodjs#2309) fix(auth): Implement automatic token refresh on supported providers (redwoodjs#2277) fix(cli): move api-server dep from api to cli (redwoodjs#2307) Static typing for cells (redwoodjs#2208) Recommended Babel package upgrades (dependabot) (redwoodjs#2255) v0.30.0 (redwoodjs#2301) upgrade Prisma v2.21.0 (redwoodjs#2273) Further improvements to CONTRIBUTING.md (redwoodjs#2261) Adds better messages for rwt link | Watcher does not exist on build failure | Only remove node_modules after a succesful framework build (redwoodjs#2269) Update named param types in router readme (redwoodjs#2262) Bump core-js from 3.6.5 to 3.10.1 (redwoodjs#2243) Fix: webpack optimizations for JS (redwoodjs#2235) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #523
What does it do?
Allows generation of cells in typescript
yarn rw g cell pets --tsAllows generation of pages in typescript
yarn rw g page kitten --tsAllows generation of scaffolds in typescript
Autodetects if your project is typescript, and flags all generators to use typescript. So no need to pass the
--tsflag all the time. In your typescript project you can just runyarn rw g page kittenand it'll infer the ts flagUpdates all the tests to use
toMatchSnapshot, and cleans up their behaviour so all the handlers are consistent.Removes depracated generators (been long enough since Sep 2020!)
What it doesn't do
Statically type cells, or handle typing cells from the outside. This is a separate piece that Peter P is looking at.