Skip to content

Further improvements to CONTRIBUTING.md#2261

Merged
dac09 merged 5 commits intomainfrom
Update-Contributing-Readme
Apr 14, 2021
Merged

Further improvements to CONTRIBUTING.md#2261
dac09 merged 5 commits intomainfrom
Update-Contributing-Readme

Conversation

@dac09
Copy link
Copy Markdown
Contributor

@dac09 dac09 commented Apr 12, 2021

Thanks to @qooqu for the improvments to this readme.

I've added a few small ones of my own.

@dac09 dac09 requested a review from jtoar April 12, 2021 15:55
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 12, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/create-redwood-app-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-api-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-api-server-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-auth-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-cli-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-core-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-dev-server-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-eslint-config-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-eslint-plugin-redwood-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-forms-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-internal-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-prerender-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-router-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-structure-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-testing-0.29.0-623b5e3.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2261/redwoodjs-web-0.29.0-623b5e3.tgz

Install this PR by running yarn rw upgrade --pr 2261:0.29.0-623b5e3

@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 12, 2021



Test summary

11 0 1 0Flakiness 0


Run details

Project RedwoodJS Framework
Status Passed
Commit 99a8cc3 ℹ️
Started Apr 13, 2021 5:33 PM
Ended Apr 13, 2021 5:36 PM
Duration 02:52 💡
OS Linux Ubuntu - 20.04
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thedavidprice
Copy link
Copy Markdown
Contributor

@dac09 If you haven't already, could you also document options for rwt link like those from #2200

@dac09
Copy link
Copy Markdown
Contributor Author

dac09 commented Apr 12, 2021

@dac09 If you haven't already, could you also document options for rwt link like those from #2200

Done ✅. Btw i've intentionally not documented the only flag, because its for advanced/unusual cases. Because our packages can depend on each other, it's best not to use it unless you really know what you're doing

Copy link
Copy Markdown
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dac09 great stuff, just some small tweaks. nothing major!

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
@dac09 dac09 merged commit 8f874c5 into main Apr 14, 2021
@dac09
Copy link
Copy Markdown
Contributor Author

dac09 commented Apr 14, 2021

Applied your suggested changes @jtoar, and merged.

@dac09 dac09 deleted the Update-Contributing-Readme branch April 14, 2021 11:13
@thedavidprice thedavidprice added this to the next-release milestone Apr 15, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Apr 21, 2021
…erve-web

* 'main' of github.com:redwoodjs/redwood: (40 commits)
  Support generating typescript cells and pages | Autodetect ts project (redwoodjs#2279)
  create-redwood-app messages: moved app start commands to end (redwoodjs#2278)
  Add import type to configuration files (redwoodjs#2214)
  Bump @reach/skip-nav from 0.13.2 to 0.15.0 (redwoodjs#2237)
  Adding Setup Deploy Render Command (redwoodjs#2099)
  Disable role linting in Routes (redwoodjs#2318)
  v0.30.1 (redwoodjs#2322)
  teardown should attempt to delete dbName table (redwoodjs#2083)
  Restore @storybook/addon-a11y (redwoodjs#2309)
  fix(auth): Implement automatic token refresh on supported providers (redwoodjs#2277)
  fix(cli): move api-server dep from api to cli (redwoodjs#2307)
  Static typing for cells (redwoodjs#2208)
  Recommended Babel package upgrades (dependabot) (redwoodjs#2255)
  v0.30.0 (redwoodjs#2301)
  upgrade Prisma v2.21.0 (redwoodjs#2273)
  Further improvements to CONTRIBUTING.md (redwoodjs#2261)
  Adds better messages for rwt link | Watcher does not exist on build failure | Only remove node_modules after a succesful framework build (redwoodjs#2269)
  Update named param types in router readme (redwoodjs#2262)
  Bump core-js from 3.6.5 to 3.10.1 (redwoodjs#2243)
  Fix: webpack optimizations for JS (redwoodjs#2235)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants