fix(cli): Cli package should depend on api server explicitly#2251
Merged
dac09 merged 1 commit intoredwoodjs:mainfrom Apr 9, 2021
Merged
fix(cli): Cli package should depend on api server explicitly#2251dac09 merged 1 commit intoredwoodjs:mainfrom
dac09 merged 1 commit intoredwoodjs:mainfrom
Conversation
Tobbe
approved these changes
Apr 9, 2021
thedavidprice
pushed a commit
that referenced
this pull request
Apr 15, 2021
peterp
added a commit
that referenced
this pull request
Apr 16, 2021
* upgrade Prisma v2.21.0 (#2273) Co-authored-by: Daniel Choudhury <[email protected]> * Fix: webpack optimizations for JS (#2235) * Add terser for JS minification * Downgrade terser to 4.x, 5+ not supported on webpack 4 * Add comment about webpack modes * Adds better messages for rwt link | Watcher does not exist on build failure | Only remove node_modules after a succesful framework build (#2269) * fix(cli): Cli package should depend on api server explicitly (#2251) * upgrade prisma v2.21.2 (#2280) * v0.30.0 Co-authored-by: David Price <[email protected]> Co-authored-by: Daniel Choudhury <[email protected]>
thedavidprice
added a commit
that referenced
this pull request
Apr 20, 2021
* upgrade Prisma v2.21.0 (#2273) Co-authored-by: Daniel Choudhury <[email protected]> * Fix: webpack optimizations for JS (#2235) * Add terser for JS minification * Downgrade terser to 4.x, 5+ not supported on webpack 4 * Add comment about webpack modes * Adds better messages for rwt link | Watcher does not exist on build failure | Only remove node_modules after a succesful framework build (#2269) * fix(cli): Cli package should depend on api server explicitly (#2251) * upgrade prisma v2.21.2 (#2280) * v0.30.0 * v0.30.1 * Update packages/api/package.json * Update packages/cli/package.json * Update packages/dev-server/package.json * Update packages/create-redwood-app/package.json * Update packages/cli/package.json * Update packages/create-redwood-app/package.json * update crwa/template/yarn.lock to v0.30.1 Co-authored-by: Daniel Choudhury <[email protected]> Co-authored-by: Peter Pistorius <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@redwoodjs/api-serveras explicit dependency to cli.This may not be a major issue, since we ask people to install
@redwoodjs/api-serveranyway, but incase you don't have it, it errors out the whole cli.