Adding Setup Deploy Render Command#2099
Conversation
|
What a great first PR Sean! Thanks 🙌 |
thedavidprice
left a comment
thedavidprice
left a comment
There was a problem hiding this comment.
Thanks for getting this rolling @SEANDOUGHTY 🚀
We still need to address the apiProxyPath config in redwood.toml.
I'll follow up with you directly as I know there are other deployment questions to address. This sets up the conversation perfectly.
Docsedit: Sean has started a PR over here https://github.com/redwoodjs/redwoodjs.com/pull/662 |
|
^^ Could you open a PR with bare-bones and reference here. I can tag team. Thinking this is a bare-bones quick start with link to Render.com (create account) and Render Redwood Docs.
^^ Gah, I wrote the incorrect link from memory. Updated with correct anchor tags for sections. Same deal here if you want to kick off a separate PR (helpful). I can tag team to finish and merge. |
Sounds good, I read through the messages and couldn't see anything actionable with regards to the code. |
|
@SEANDOUGHTY I caught a couple of last issues running through the process locally. Should be easy to wrap up! Also, I set up render on a brand for my QA project here: And I created a Web service in my Render dashboard and then connected my repo and set the branch. Do I need to also create a Static Site and Database? I had the assumption that the config would pull from my Web service on the first deploy and then automatically link and create services as needed. Maybe that is the case but having config in my branch is messing it up? I guess I'll know more once the Render docs are live. |
Co-authored-by: David Price <[email protected]>
| return `services: | ||
| - type: web | ||
| name: ${PROJECT_NAME}-web | ||
| - name: ${PROJECT_NAME}-web |
There was a problem hiding this comment.
As discussed, I swapped the type and name to be a bit more clear to the user.
|
Ready for final review @SEANDOUGHTY? Looking very good! |
Co-authored-by: Daniel Choudhury <[email protected]>
dac09
left a comment
dac09
left a comment
There was a problem hiding this comment.
Setup command worked beautifully!
Things to note:
- Get a 404 on https://render.com/docs/deploy-redwood (probably just awaiting deploy)
- Healthz function should potentially check the prisma/db connection, because that's most likely where things go wrong
…erve-web * 'main' of github.com:redwoodjs/redwood: (40 commits) Support generating typescript cells and pages | Autodetect ts project (redwoodjs#2279) create-redwood-app messages: moved app start commands to end (redwoodjs#2278) Add import type to configuration files (redwoodjs#2214) Bump @reach/skip-nav from 0.13.2 to 0.15.0 (redwoodjs#2237) Adding Setup Deploy Render Command (redwoodjs#2099) Disable role linting in Routes (redwoodjs#2318) v0.30.1 (redwoodjs#2322) teardown should attempt to delete dbName table (redwoodjs#2083) Restore @storybook/addon-a11y (redwoodjs#2309) fix(auth): Implement automatic token refresh on supported providers (redwoodjs#2277) fix(cli): move api-server dep from api to cli (redwoodjs#2307) Static typing for cells (redwoodjs#2208) Recommended Babel package upgrades (dependabot) (redwoodjs#2255) v0.30.0 (redwoodjs#2301) upgrade Prisma v2.21.0 (redwoodjs#2273) Further improvements to CONTRIBUTING.md (redwoodjs#2261) Adds better messages for rwt link | Watcher does not exist on build failure | Only remove node_modules after a succesful framework build (redwoodjs#2269) Update named param types in router readme (redwoodjs#2262) Bump core-js from 3.6.5 to 3.10.1 (redwoodjs#2243) Fix: webpack optimizations for JS (redwoodjs#2235) ...
8 participants
The PR adds a command to the Redwood CLI to automatically configure project for deployment to Render.