Move whatwg-fetch from devDep to dep by Tobbe · Pull Request #1625 · redwoodjs/graphql

Tobbe · 2021-01-12T08:30:26Z

github-actions · 2021-01-12T08:34:44Z

Install this PR by running yarn rw upgrade --pr 1625:0.22.1-3520c0b

Tobbe · 2021-01-12T08:54:30Z

Demonstrating that it doesn't work without this PR

tobbe@XPS9550 MINGW64 ~/dev/redwood
$ yarn create redwood-app whatwgfetch
yarn create v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
[...]
Done in 58.87s.

tobbe@XPS9550 MINGW64 ~/dev/redwood
$ cd whatwgfetch/

tobbe@XPS9550 MINGW64 ~/dev/redwood/whatwgfetch
$ yarn rw g page test
yarn run v1.22.4
$ C:\Users\tobbe\dev\redwood\whatwgfetch\node_modules\.bin\rw g page test
  √ Generating page files...
    √ Successfully wrote file `./web\src\pages\TestPage\TestPage.stories.js`
    √ Successfully wrote file `./web\src\pages\TestPage\TestPage.test.js`
    √ Successfully wrote file `./web\src\pages\TestPage\TestPage.js`
  √ Updating routes file...
Done in 4.37s.

tobbe@XPS9550 MINGW64 ~/dev/redwood/whatwgfetch
$ yarn why whatwg-fetch
yarn why v1.22.4
[1/4] Why do we have the module "whatwg-fetch"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
error We couldn't find a match!
Done in 1.48s.

tobbe@XPS9550 MINGW64 ~/dev/redwood/whatwgfetch
$ yarn rw test
[...]
$ C:\Users\tobbe\dev\redwood\whatwgfetch\node_modules\.bin\jest --passWithNoTests --watchAll --runInBand --config C:\Users\tobbe\dev\redwood\whatwgfetch\node_modules\@redwoodjs\core\config\jest.config.js --projects web api
 FAIL   web  web/src/pages/TestPage/TestPage.test.js
  ● Test suite failed to run

    Cannot find module 'whatwg-fetch' from '../node_modules/@redwoodjs/core/dist/configs/browser/jest.setup.js'

      at Resolver.resolveModule (../node_modules/jest-resolve/build/index.js:306:11)
      at Object.<anonymous> (../node_modules/@redwoodjs/core/dist/configs/browser/jest.setup.js:5:1)

Demonstrating that we get further with this PR

tobbe@XPS9550 MINGW64 ~/dev/redwood/whatwgfetch
$ yarn rw upgrade --pr 1625:0.22.1-3520c0b
yarn run v1.22.4
$ C:\Users\tobbe\dev\redwood\whatwgfetch\node_modules\.bin\rw upgrade --pr 1625:0.22.1-3520c0b
[...]
success Saved lockfile.
success Saved 2 new dependencies.
info Direct dependencies
└─ @redwoodjs/[email protected]
info All dependencies
├─ @redwoodjs/[email protected]
└─ [email protected]
[...]
Done in 60.00s.

tobbe@XPS9550 MINGW64 ~/dev/redwood/whatwgfetch
$ yarn rw test
[...]
$ C:\Users\tobbe\dev\redwood\whatwgfetch\node_modules\.bin\jest --passWithNoTests --watchAll --runInBand --config C:\Users\tobbe\dev\redwood\whatwgfetch\node_modules\@redwoodjs\core\config\jest.config.js --projects web api
 FAIL   web  web/src/pages/TestPage/TestPage.test.js
  ● Test suite failed to run

    Cannot find module '@redwoodjs/router/dist/index' from '../node_modules/@redwoodjs/testing/dist/MockRouter.js'

    Require stack:
      C:/Users/tobbe/dev/redwood/whatwgfetch/node_modules/@redwoodjs/testing/dist/MockRouter.js
      src/Routes.js
      C:/Users/tobbe/dev/redwood/whatwgfetch/node_modules/@redwoodjs/testing/dist/MockProviders.js
      C:/Users/tobbe/dev/redwood/whatwgfetch/node_modules/@redwoodjs/testing/dist/customRender.js
      C:/Users/tobbe/dev/redwood/whatwgfetch/node_modules/@redwoodjs/testing/dist/index.js
      C:/Users/tobbe/dev/redwood/whatwgfetch/node_modules/@redwoodjs/core/dist/configs/browser/jest.setup.js

      at Resolver.resolveModule (../node_modules/jest-resolve/build/index.js:306:11)
      at Object.<anonymous> (../node_modules/@redwoodjs/testing/dist/MockRouter.js:31:14)

So with this PR it doesn't complain about whatwg-fetch missing anymore. But now it breaks on MockRouter instead. I don't think that's related to this PR though.

thedavidprice · 2021-01-12T16:04:17Z

The package is also included in redwood/package.json.

We don't need both, do we?

Tobbe · 2021-01-12T18:03:41Z

@thedavidprice I noticed that too. I did dig in to it a little bit. It was added to that file by @peterp in this commit

commit da6ebb41bb02d5eaf43495726fcea0ce46397e34
Author: Peter Pistorius <[email protected]>
Date:   Sun Jun 14 14:31:26 2020 +0200

    Move testing things to global package.

diff --git a/package.json b/package.json
index 5dbbb66b..22d0ec86 100644
--- a/package.json
+++ b/package.json
@@ -16,11 +16,16 @@
     "@babel/runtime-corejs3": "^7.9.2",
     "babel-plugin-auto-import": "^1.0.5",
     "babel-plugin-module-resolver": "^4.0.0",
+    "bundlesize": "^0.18.0",
     "cross-env": "^7.0.2",
     "jest": "^25.2.3",
     "lerna": "^3.20.2",
     "nodemon": "^2.0.2",
-    "typescript": "^3.8.3"
+    "typescript": "^3.8.3",
+    "@testing-library/react": "10.2.1",
+    "@testing-library/jest-dom": "5.10.0",
+    "msw": "0.19.3",
+    "whatwg-fetch": "3.0.0"
   },
   "eslintConfig": {
     "extends": "@redwoodjs/eslint-config",
@@ -43,4 +48,4 @@
     "lint": "yarn eslint packages",
     "lint:fix": "yarn eslint --fix packages"
   }
-}
+}
\ No newline at end of file

If whatwg-fetch should be removed, should we remove the other packages too? Or should whatwg-fetch only be in this top level package.json, but moved to dependencies? The top level package.json doesn't have any other deps, only devDeps. @peterp What do you think?

thedavidprice · 2021-01-12T23:07:44Z

Opened a new issue with the comment above here: #1631

Move whatwg-fetch from devDep to dep

3520c0b

Fixes redwoodjs#1581

peterp approved these changes Jan 12, 2021

View reviewed changes

Tobbe merged commit 68fed52 into redwoodjs:main Jan 12, 2021

thedavidprice added this to the next release milestone Jan 12, 2021

thedavidprice mentioned this pull request Jan 12, 2021

resolve test package dependency duplicates #1631

Closed

Tobbe deleted the tobbe-whatwgfetch branch January 13, 2021 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move whatwg-fetch from devDep to dep#1625

Move whatwg-fetch from devDep to dep#1625
Tobbe merged 1 commit intoredwoodjs:mainfrom
Tobbe:tobbe-whatwgfetch

Tobbe commented Jan 12, 2021

Uh oh!

github-actions Bot commented Jan 12, 2021

Uh oh!

Tobbe commented Jan 12, 2021

Uh oh!

thedavidprice commented Jan 12, 2021

Uh oh!

Tobbe commented Jan 12, 2021

Uh oh!

thedavidprice commented Jan 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Tobbe commented Jan 12, 2021

Uh oh!

github-actions Bot commented Jan 12, 2021

Uh oh!

Tobbe commented Jan 12, 2021

Uh oh!

thedavidprice commented Jan 12, 2021

Uh oh!

Tobbe commented Jan 12, 2021

Uh oh!

thedavidprice commented Jan 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants