Resolve promises in the console#1619
Merged
thedavidprice merged 3 commits intomainfrom Jan 12, 2021
Merged
Conversation
Member
|
Nice! |
peterp
approved these changes
Jan 9, 2021
jtoar
commented
Jan 12, 2021
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jan 14, 2021
…ender-p1 * 'main' of github.com:redwoodjs/redwood: v0.23.0 GH Action PR Comment: Formatting add learn.rwjs.com repo to contributors (redwoodjs#1634) update PR Package Action formatting Updated All-Contributors Data (redwoodjs#1621) sync yarn.lock (redwoodjs#1632) Resolve promises in the console (redwoodjs#1619) Replace prisma deprecated fineOne() -> findUnique() (redwoodjs#1629)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another way of abstracting away the need for top-level await in the redwood console, by automatically resolving promises (cc @mojombo from today's contributor's meetup).
A really nice copy-paste fix I took from the resources referenced in #1613 (comment) ("hack the eval").
Also tagging @peterp just in case you want to take a look at this one too. Guled brought up the good point that even if we enable top-level await, it might be annoying to have to type "await ..." all the time.