Abstract away NODE_OPTIONS exp. await flag for console#1603
Closed
Abstract away NODE_OPTIONS exp. await flag for console#1603
Conversation
Contributor
|
Current Issues:
Most likely need to resolve post the release of v0.22. Hold off on promotion and including in Tutorial 2 until fixed and in a release. |
Contributor
|
@peterp This is a weird one all around. Could you take a look and see if you have some ideas for how to better approach in general? |
Member
|
@jtoar I think we can close this now? |
Member
|
Closing this because we merged something else in #1619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console command requires the
NODE_OPTIONSenv var to be set to--experimental-repl-await. This PR makes it so that the console command spawns an execa child process to configure it automatically so that users don't have to.This solution's based on the comment here: nodejs/node#13209 (comment).