feat: add DisableTCPNoDelay#650
Merged
Merged
Conversation
Signed-off-by: Rueian <[email protected]>
rueian
changed the title
rueian
marked this pull request as ready for review
October 20, 2024 07:15
Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
perf-no-nodelay-pipeline
branch
from
October 20, 2024 07:18
912f223 to
dd258a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found that turning on Nagle's algorithm (
DisableTCPNoDelay=true) may improve performance depending on the network condition and workloads, especially when all your requests are small and your network interfaces are relatively slow.Benchmark results on 2 GCP n2-highcpu-2 machines (client and redis server):
PipelineMultiplex=-1 (1 connection):
PipelineMultiplex=1 (2 connections):
PipelineMultiplex=2 (4 connections):
