feat(cmds): add Redis array command builders#1002
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit b8529b2. Configure here.
b8529b2 to
e2b8cad
Compare
|
CI is now complete on the updated head I did not find a CODEOWNERS file in the repo root, |
|
Friendly follow-up: this still looks ready for maintainer review. Current head Review focus: the new array command builders are generated consistently with the existing command-builder patterns, and the earlier CI/proof note has the exact passing check summary. Happy to adjust anything maintainers want changed. |
|
Hi @kiranmagic7, could you help delete |
e2b8cad to
e013bd1
Compare
|
Addressed, thank you. Changed:
Local verification:
I also tried |
2 participants
Closes #1000.
Summary
hack/cmds/commands_array.jsonwith the 18 Redis 8.8 AR* command specs from Redisunstable/src/commandsarraycommand builders and generated builder-path testsreadOnlyCMDsso generated builders keep the readonly command flagTests
PATH="/Users/kiran/go/bin:$PATH" go generate ./...go test ./internal/cmds -run 'TestCommand_.*_array' -count=1go test ./internal/cmds -count=1go test ./... -run '^$'git diff HEAD^..HEAD --checkCompatibility
Generated command-builder additions only. Existing command builders are unchanged; AR write commands are normal completed commands, and AR read commands get the same readonly flag as other read-only Redis commands.
Note
Low Risk
Additive generated API and generator logic only; existing builders unchanged aside from shared gen.go path/oneof behavior for ARGREP-style commands.
Overview
Adds Redis 8.8 array support to the typed command builder by introducing
hack/cmds/commands_array.json(18 AR* commands) and regeneratinginternal/cmds/gen_array.goplus path tests.hack/cmds/gen.gois extended soARGREPbuilds correctly: variadic oneof handling, AND/OR connectors that chain into further predicates, and path generation that avoids invalid duplicate predicate steps. Read-only AR commands are registered inreadOnlyCMDsso generated roots get thereadonlyflag.A focused
TestArgrepBuildsMultiplePredicatesasserts multi-predicate ARGREP wire format and readonly behavior.Reviewed by Cursor Bugbot for commit e013bd1. Bugbot is set up for automated code reviews on this repo. Configure here.