Repository navigation
chore(deps): bump the uv group across 1 directory with 2 updates - #751
Merged
Merged
Conversation
Bumps the uv group with 2 updates in the / directory: [fsspec](https://github.com/fsspec/filesystem_spec) and [multidict](https://github.com/aio-libs/multidict). Updates `fsspec` from 2026.4.0 to 2026.6.0 - [Commits](fsspec/filesystem_spec@2026.4.0...2026.6.0) Updates `multidict` from 6.7.1 to 6.9.1 - [Release notes](https://github.com/aio-libs/multidict/releases) - [Changelog](https://github.com/aio-libs/multidict/blob/master/CHANGES.rst) - [Commits](aio-libs/multidict@v6.7.1...v6.9.1) --- updated-dependencies: - dependency-name: fsspec dependency-version: 2026.6.0 dependency-type: indirect dependency-group: uv - dependency-name: multidict dependency-version: 6.9.1 dependency-type: indirect dependency-group: uv ... Signed-off-by: dependabot[bot] <[email protected]>
vishal-bala
approved these changes
Oct 26, 2026
vishal-bala
added a commit
that referenced
this pull request
Oct 30, 2026
…ce tests (#802) ## Motivation Every Dependabot PR fails CI on two jobs, Service Tests and Notebook Validation, regardless of what it bumps. Dependabot pushes its branches to this repository, so its PRs pass the same-repository guard that keeps fork PRs away from secret-dependent jobs. GitHub, however, gives runs that Dependabot triggers no Actions secrets, so those jobs start with every API key empty. On #751, Service Tests stops at the Google Cloud authentication step for want of `GOOGLE_CREDENTIALS`, and the notebooks fall through to `getpass` prompts that cannot run in CI. The same two jobs failed on #744, #749, #751 and #799. ## Changes This PR treats Dependabot PRs the way fork PRs are already treated: the secret-dependent jobs skip, and a maintainer runs them with secrets after reading the change. - `.github/workflows/test.yml`: Service Tests and Notebook Validation also skip when `github.actor` is `dependabot[bot]`. The guard keys on the actor because that is what GitHub withholds secrets on, so a maintainer's push to a Dependabot branch still runs both jobs with secrets. - `.github/workflows/test-fork-pr.yml`: the dispatch-only workflow now accepts PRs opened by `dependabot[bot]` as well as fork PRs, and still rejects other same-repository PRs. - `CONTRIBUTING.md`: a short section telling maintainers to run `gh workflow run test-fork-pr.yml -f pr_number=<n>` before merging a fork or Dependabot PR. ## Notes - A skipped job shows as passing, so the manual dispatch is a convention, not an enforced gate. Copying the API keys into the Dependabot secrets store would make the jobs run automatically, but it would also hand those keys to newly bumped dependency code before anyone has reviewed it, which defeats the purpose of waiting for a maintainer. - The check run keeps the name "Fork PR - Service Tests" so that any branch-protection rule or tooling referring to it keeps matching. - Notebook Validation has no manual equivalent, as is already the case for fork PRs. It still runs on `main` after merge and nightly. ## Reviewer Brief **Start here:** `.github/workflows/test.yml:25`, the Service Tests `if:` guard. It decides which PR runs get secret-dependent jobs, and the Notebook Validation guard at `:152` repeats it. **Where it could fail** - `.github/workflows/test-fork-pr.yml:46-51`: the new acceptance checks who opened the PR (`pr.data.user.login`), not who wrote its commits, so a write-access user's commit on a Dependabot branch would also be tested with secrets; that user can already run code with secrets from any same-repository branch. **Not verified:** neither workflow has run with this change. The `github.actor` guard and the Dependabot acceptance in `test-fork-pr.yml` can only be confirmed on a real Dependabot PR plus a manual dispatch. actionlint was not available; both files parse as YAML, and the `setup` script passes `node --check`. **Beyond CI:** the logs of run 37937957172 (#751) show every secret empty on a Dependabot-triggered run, Service Tests failing at Google Cloud authentication, and Notebook Validation failing on `getpass` API-key prompts, which confirms that both jobs need secrets and lose no working coverage by skipping. **Since the last brief:** `a59789b7` passes `GEMINI_API_KEY` to the dispatched service tests, matching `test.yml`, so the Google GenAI fixture exercises the Gemini backend there too. <sub>Reviewed `d8a7d3a7` · Claude Code (claude-opus-5-5) · lenses: correctness, security, design, tests, docs, Redis behaviour</sub> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Workflow and contributor-doc changes only; no application or secret-handling logic changes, though skipped jobs still report as passing until a maintainer runs the dispatch workflow. > > **Overview** > Dependabot PRs were hitting **Service Tests** and **Notebook Validation** with no Actions secrets (same-repo branches, but GitHub withholds secrets on Dependabot-triggered runs), so CI failed on empty API keys. This PR aligns Dependabot with the existing fork PR pattern. > > **`test.yml`** skips those secret-dependent jobs when `github.actor` is `dependabot[bot]` (while still running them for maintainer pushes on the same branch). **`test-fork-pr.yml`** now allows manual dispatch for Dependabot PRs as well as forks, with updated validation and comments. **`CONTRIBUTING.md`** documents running `gh workflow run test-fork-pr.yml -f pr_number=<n>` before merge. > > The fork-pr workflow also wires **`GEMINI_API_KEY`** into the service-tests env alongside the other provider secrets. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a59789b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the uv group with 2 updates in the / directory: fsspec and multidict.
Updates
fsspecfrom 2026.4.0 to 2026.6.0Commits
a245700changelog (#2049)652325dFix async cat ranges on error (#2045)073aac8Forward kwargs from cat_ranges to cat_file (#2044)2818611FTP: preserve filenames containing whitespace in _mlsd2 (#2043)c879384Prevent attribute error by checking for 'forced' attribute before flushing ca...71b8a6bReflect async _walk correctly (#2040)5eec9f9Fix: Omitthreading.get_ident()from cache token for async implementations ...8643878Small safety improvements (#2039)a1c16abHonour simple_templates everywhere in referenceFS (#2029)85facaaFix infinite recursion in expand_path when resolving paths with glob magic ch...Updates
multidictfrom 6.7.1 to 6.9.1Release notes
Sourced from multidict's releases.
... (truncated)
Changelog
Sourced from multidict's changelog.
... (truncated)
Commits
0a1770cRelease 6.9.1 (#1504)d220522Upload release assets one at a time to avoid the secondary rate limit (#1503)30cd596Stop a GIL-releasing del from segfaulting the standard C extension build ...d1c331aRecheck the reader gate after taking the retired list (#1502)b37f07cAllocate deferred decrefs in fixed-size blocks (#1501)563f667Run CodSpeed benchmarks on Python 3.14 and loop the smallest ones (#1498)157c87cCancel superseded CI runs on pull requests (#1500)d43adfeDrop -I from the ASan test command so PYTHONMALLOC takes effect (#1499)2a68472Stop items() iteration from reading a freed entry in CIMultiDict (#1496)cd528d6Rename GHSA-54p9-h82j-f925 changelog fragment to the merged commit (#1495)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.
Note
Low Risk
Lockfile-only transitive dependency bumps with no direct code changes; multidict updates harden aiohttp’s header handling under concurrency.
Overview
This PR only updates
uv.lockas part of a Dependabot uv dependency-group bump—nopyproject.tomlor application code changes.It pins
fsspec2026.4.0 → 2026.6.0 (transitive, e.g. viahuggingface_hub) andmultidict6.7.1 → 6.9.1 (transitive viaaiohttp), including refreshed wheel/sdist hashes and an expandedmultidictwheel matrix (e.g. RISC64, Android/iOS).The
multidictjump is mainly C-extension concurrency and memory-safety fixes (including free-threaded builds and standard-build segfault hardening);fsspecis a minor release with async/filesystem bug fixes per upstream.Reviewed by Cursor Bugbot for commit b587958. Bugbot is set up for automated code reviews on this repo. Configure here.