Repository navigation
Commit 8a70416
committed
refactor(router): derive the async index from the sync one
Address review on #784:
- _get_async_index reads the URL, connection kwargs, lib_name and client
ownership from self._index instead of keeping copies on the router,
which also makes the from_existing patch unnecessary.
- aroute/aroute_many take everything after vector keyword-only, so a
positional distance_threshold can't be read as an aggregation method.
- Docstrings note that SSL, unix-socket, Sentinel and Cluster clients
should pass redis_url for async routing, that vectorizers without a
native aembed still block on embedding, and that adisconnect() must be
called before switching event loops.
- Replace the six async tests with one that blocks the sync embed and
sync aggregate paths, so it fails if aroute takes either.1 parent 54b6f0a commit 8a70416
2 files changed
Lines changed: 44 additions & 87 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | 56 | | |
62 | 57 | | |
63 | 58 | | |
| |||
145 | 140 | | |
146 | 141 | | |
147 | 142 | | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | 143 | | |
153 | 144 | | |
154 | 145 | | |
| |||
228 | 219 | | |
229 | 220 | | |
230 | 221 | | |
231 | | - | |
| 222 | + | |
232 | 223 | | |
233 | 224 | | |
234 | 225 | | |
| |||
241 | 232 | | |
242 | 233 | | |
243 | 234 | | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | 235 | | |
250 | 236 | | |
251 | 237 | | |
| |||
567 | 553 | | |
568 | 554 | | |
569 | 555 | | |
570 | | - | |
571 | | - | |
572 | | - | |
573 | | - | |
574 | | - | |
| 556 | + | |
| 557 | + | |
575 | 558 | | |
576 | | - | |
577 | | - | |
578 | | - | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
579 | 563 | | |
580 | 564 | | |
581 | 565 | | |
582 | | - | |
583 | | - | |
584 | | - | |
585 | | - | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
586 | 571 | | |
587 | 572 | | |
588 | 573 | | |
| |||
729 | 714 | | |
730 | 715 | | |
731 | 716 | | |
| 717 | + | |
732 | 718 | | |
733 | 719 | | |
734 | 720 | | |
| |||
738 | 724 | | |
739 | 725 | | |
740 | 726 | | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
741 | 735 | | |
742 | 736 | | |
743 | 737 | | |
| |||
768 | 762 | | |
769 | 763 | | |
770 | 764 | | |
| 765 | + | |
771 | 766 | | |
772 | 767 | | |
773 | 768 | | |
774 | 769 | | |
775 | | - | |
| 770 | + | |
| 771 | + | |
776 | 772 | | |
777 | 773 | | |
778 | 774 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
819 | 819 | | |
820 | 820 | | |
821 | 821 | | |
822 | | - | |
| 822 | + | |
823 | 823 | | |
824 | | - | |
825 | | - | |
826 | | - | |
827 | | - | |
828 | | - | |
829 | | - | |
830 | | - | |
831 | | - | |
832 | | - | |
| 824 | + | |
| 825 | + | |
833 | 826 | | |
834 | | - | |
835 | | - | |
836 | | - | |
837 | | - | |
838 | | - | |
839 | | - | |
840 | | - | |
841 | | - | |
842 | | - | |
843 | | - | |
844 | | - | |
845 | | - | |
846 | | - | |
847 | | - | |
848 | | - | |
849 | | - | |
850 | | - | |
851 | | - | |
852 | | - | |
853 | | - | |
854 | | - | |
855 | | - | |
856 | | - | |
857 | | - | |
858 | | - | |
859 | | - | |
860 | | - | |
861 | | - | |
862 | | - | |
863 | | - | |
864 | | - | |
865 | | - | |
866 | | - | |
867 | | - | |
868 | | - | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
869 | 830 | | |
| 831 | + | |
| 832 | + | |
870 | 833 | | |
871 | | - | |
872 | | - | |
873 | | - | |
874 | | - | |
875 | | - | |
876 | | - | |
877 | | - | |
878 | | - | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
879 | 837 | | |
880 | | - | |
881 | | - | |
882 | | - | |
883 | | - | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
884 | 844 | | |
885 | | - | |
886 | | - | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
887 | 848 | | |
888 | 849 | | |
889 | 850 | | |
| |||
0 commit comments