Normalize NAN to a single nan type#11
Merged
oranagra merged 3 commits intoredis:masterfrom Jan 5, 2023
Merged
Conversation
In redis/redis#11597, Redis 7.2, we normalized NaN in Redis to a single nan type, like we already normalized inf.
zuiderkwast
reviewed
Dec 9, 2022
Co-authored-by: Viktor Söderqvist <[email protected]>
enjoy-binbin
commented
Dec 10, 2022
Member
|
Looks like this was resolved in #9 |
Contributor
@itamarhaber No, #9/#10 added |
Member
|
Thanks @zuiderkwast - my bad as usual. |
Contributor
|
@itamarhaber No problem. Btw, do you want to merge this one? When merging, we should set today's date in the Version history (see comment above). |
Contributor
oranagra
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In redis/redis#11597, Redis 7.2,
we normalized NaN in Redis to a single nan type, like we
already normalized inf.