Export REDIS_MAJOR_VERSION correctly in run-tests#3642
Merged
petyaslavova merged 1 commit intoredis:masterfrom May 12, 2025
Merged
Export REDIS_MAJOR_VERSION correctly in run-tests#3642petyaslavova merged 1 commit intoredis:masterfrom
petyaslavova merged 1 commit intoredis:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects how the REDIS_MAJOR_VERSION is exported in the run-tests workflow to address issues noted by @akx.
- Consolidates exporting of REDIS_MAJOR_VERSION by moving the echo command outside the conditional block
- Removes the duplicated export to ensure consistency in setting the variable
petyaslavova
approved these changes
May 12, 2025
petyaslavova
pushed a commit
to Kakadus/redis-py
that referenced
this pull request
May 13, 2025
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jun 30, 2025
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue spotted by @akx #3415 (comment) in run-tests reusable workflow