add queue_class to REDIS_ALLOWED_KEYS#2577
Merged
dvora-h merged 4 commits intoMar 16, 2023
Merged
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2577 +/- ##
===========================================
- Coverage 92.29% 77.66% -14.63%
===========================================
Files 115 115
Lines 29763 28867 -896
===========================================
- Hits 27469 22419 -5050
- Misses 2294 6448 +4154
... and 69 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dvora-h
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.
#2547 has added support for custom connection pool in RedisCluster, but RedisCluster doesn't allow custom queue_class to be used in BlockingConnectionPool.
This PR adds support for custom queue_class that can be used in BlockingConnectionPool
reference to queue_class in BlockingConnectionPool:
redis-py/redis/connection.py
Lines 1555 to 1570 in 428d609