tox.ini: get rid of typoed healthcheck stanzas#2387
Closed
akx wants to merge 2 commits into
Closed
Conversation
akx
force-pushed
the
get-rid-of-healthcheck
branch
from
915e3b6 to
8bb681b
Compare
6 tasks
Contributor
Author
|
In light of #2390, this may not be a good idea. |
akx
force-pushed
the
get-rid-of-healthcheck
branch
from
8bb681b to
05c24a5
Compare
Contributor
Author
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
==========================================
- Coverage 92.29% 92.29% -0.01%
==========================================
Files 116 116
Lines 30189 30189
==========================================
- Hits 27864 27863 -1
- Misses 2325 2326 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Friendly ping, @chayim :) |
Since the actual configuration should be `healthcheck_cmd`, there's probably no good reason to keep no-op configuration in tox.ini.
akx
force-pushed
the
get-rid-of-healthcheck
branch
from
05c24a5 to
f2dae0e
Compare
Collaborator
|
Not relevant anymore (see #2793) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?Description of change
Since the actual configuration should be
healthcheck_cmd, there's probably no good reason to keep no-op configuration in tox.ini.Closes #2395 (alternate take)