Add description of WITHSCORE argument to ZRANK and ZREVRANK.#2227
Add description of WITHSCORE argument to ZRANK and ZREVRANK.#2227zuiderkwast merged 3 commits intoredis:masterfrom
Conversation
✅ Deploy Preview for redis-doc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
LGTM.
technically, json file changes aren't needed (the file is auto generated).
merging them may cause some issues (although more likely just be overwritten).
@itamarhaber correct me if i'm wrong, but merging it will immediately appear in redis.io, so not sure what's the proffered approach these days.
|
Also LGTM.
They are only needed if we want the new syntax to be shown. I assume that @CharlesChen888 generated commands.json using the standard script (https://github.com/redis/redis/blob/unstable/utils/generate-commands-json.py) and that this is just the diff.
You're not wrong or put differently, you're totally correct. I don't see a big issue with that, but this is apt to anger some users who won't notice the version note (and the breaking example until we release 7.2-rc1 as well). |
Oh... I didn't realize this. |
5 participants
For PR redis/redis#11235, which adds the
WITHSCOREoption to commandZRANKandZREVRANK.Add description of option
WITHSCOREargument tozrank.mdandzrevrank.md.Modify
commands.json.