Merged
Conversation
zuiderkwast
reviewed
Feb 28, 2022
commands/cluster-info.md
Outdated
| * `total_cluster_links_buffer_limit_exceeded`: Accumulated count of cluster links freed due to exceeding the `cluster-link-sendbuf-limit` configuration. | ||
|
|
||
| More information about the Current Epoch and Config Epoch variables are available in the Redis Cluster specification document. | ||
| The following message-related fields may be included in the mapped reply if the value is not equal 0: |
Contributor
There was a problem hiding this comment.
Need to add "to" in "is not equal to 0".
Other possibilities: "is not equal to zero" or just "is not zero".
Contributor
There was a problem hiding this comment.
I also think the term mapped reply might be confusing, since it's not a RESP map.
madolson
reviewed
Mar 8, 2022
commands/cluster-info.md
Outdated
| * `total_cluster_links_buffer_limit_exceeded`: Accumulated count of cluster links freed due to exceeding the `cluster-link-sendbuf-limit` configuration. | ||
|
|
||
| More information about the Current Epoch and Config Epoch variables are available in the Redis Cluster specification document. | ||
| The following message-related fields may be included in the mapped reply if the value is not equal 0: |
Contributor
There was a problem hiding this comment.
I also think the term mapped reply might be confusing, since it's not a RESP map.
commands/cluster-info.md
Outdated
| Each message type includes statistics on the number of messages sent and received. | ||
| Here are the explanation of these message types: | ||
|
|
||
| * `ping`: PING |
Contributor
There was a problem hiding this comment.
ping/pong/meet also contain gossip information.
Contributor
Author
There was a problem hiding this comment.
yes, should we mention that? or how should i mention that...
itamarhaber
approved these changes
May 31, 2022
Member
itamarhaber
left a comment
itamarhaber
left a comment
There was a problem hiding this comment.
Thanks @enjoy-binbin - sorry for the freeze-out - merging.
slorello89
added a commit
to slorello89/redis-doc
that referenced
this pull request
Jun 3, 2022
README updates, moving from dictionary.txt -> wordlist adding spellchecker-cli to wordlist. . . so meta Update README about clients (redis#1886) Add documentation documenting read-only scripts (redis#1953) Based on discussion from redis/redis#10728 (comment), want to better define when to use `EVAL` et. al vs `EVAL_RO` et al. to be modified again soon in redis#1954 Add info fields about network bytes during replication. (redis#1966) Co-authored-by: jiangyujie.jyj <[email protected]> Update key-specs.md (redis#1963) Fix "incomplete flag section" internal page link Update install-redis-on-windows.md (redis#1967) Duplicate "install" word. Update command-getkeysandflags.md (redis#1946) Update install-redis-on-mac-os.md (redis#1938) Small grammar fixes fix incorrect link (redis#1926) Add CLUSTER INFO fields (redis#1798) script flags update (redis#1954) updating docs about read only scripts and oom related flag changes in 7.0.1 minor fixes adding spellcheck config and commands file adding workflow dispatch newline newline debug newline duh whitespace more whitespace this ought to do it. this ought to do it. alright, this really ought to do it. no clobber just ignore COMMAND_FILES* pointing at main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the changes in redis/redis@c5d6f57, those(all) stat fields are not documented. https://redis.io/commands/cluster-info
@madolson lack of knowledge of cluster and english, please take it from here...