Documentation for ACL V2 + ACL DRYRUN#1756
Merged
madolson merged 7 commits intoredis:masterfrom Jan 28, 2022
Merged
Conversation
6 tasks
zuiderkwast
reviewed
Jan 27, 2022
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks pretty good in general.
oranagra
reviewed
Jan 27, 2022
Contributor
Author
|
@zuiderkwast Thanks for the comments! I still stuck with the "root" terminology, since it makes the most sense to me. In both cases it is defined before usage. If you still feel strongly I would be okay switch it to "main" or "primary" permissions as well. |
oranagra
approved these changes
Jan 28, 2022
zuiderkwast
approved these changes
Jan 28, 2022
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
A few final comments, then I'm happy.
Contributor
Author
|
@zuiderkwast Good enough to make you happy? |
Contributor
|
Fine, although it's VIRGINIA in DRYRUN and virginia in SETUSER. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference implementation: redis/redis#9974