Skip to content

Updated docs to include INFO latencystats and LATENCY HISTOGRAM#1733

Merged
zuiderkwast merged 15 commits intoredis:masterfrom
filipecosta90:extended.latency.docs
Jan 25, 2022
Merged

Updated docs to include INFO latencystats and LATENCY HISTOGRAM#1733
zuiderkwast merged 15 commits intoredis:masterfrom
filipecosta90:extended.latency.docs

Conversation

@filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Jan 5, 2022

Apart from the INFO latencystats and LATENCY HISTOGRAM additions, there is also the:

@itamarhaber changed a minor typo on Readme also.

@oranagra
Copy link
Member

oranagra commented Jan 5, 2022

@itamarhaber @yoav-steinberg @zuiderkwast we may need to come up with a plan quickly.
while there's one pending PR that updates the commands.json, any other PR that's opened to do the same will have conflicts.
maybe git can automatically solve them (being identical), but i think GH still shows a conflict, which will require an extra manual step.

@filipecosta90 filipecosta90 requested a review from oranagra January 5, 2022 14:36
@filipecosta90 filipecosta90 requested a review from oranagra January 5, 2022 15:10
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I didn't look at the details.

Regarding RESP3, we should really do something about #1521 soon, perhaps for 7.0....

Regarding commands.json, we should have some way to fetch it from Redis when the website is updated. Then we can ignore commands.json in the redis-doc repo and later delete it.

Copy link
Contributor

@yoav-steinberg yoav-steinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions.

Copy link
Contributor

@yoav-steinberg yoav-steinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oranagra oranagra added the to-be-merged should probably be merged soon label Jan 18, 2022
@zuiderkwast zuiderkwast merged commit af0393f into redis:master Jan 25, 2022
hpatro pushed a commit to hpatro/redis-doc that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to-be-merged should probably be merged soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants