Merged
Conversation
13 tasks
zuiderkwast
reviewed
Nov 30, 2021
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks good!
I didn't proof read the examples, assuming they're generated.
Do we need to wait for and/or coordinate with redis/redis#9656 regarding commands.json?
oranagra
added
to-be-merged
Member
|
@itamarhaber what the hell happened to commands.json in this PR? |
Member
|
ohh, this PR is based on a very old version of the master branch. |
oranagra
approved these changes
Feb 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream ref: redis/redis#9127
update commands .json from unstable (pre 7.0 RC2)