Skip to content

Add new async_loading field in INFO command#1686

Merged
yoav-steinberg merged 2 commits intoredis:masterfrom
enjoy-binbin:add_async_loading
Nov 27, 2021
Merged

Add new async_loading field in INFO command#1686
yoav-steinberg merged 2 commits intoredis:masterfrom
enjoy-binbin:add_async_loading

Conversation

@enjoy-binbin
Copy link
Contributor

Added in redis/redis#9323

@oranagra
Copy link
Member

Thanks, indeed e should have documented it and forgot.
But I think the text should be improved to add more details, I.e. State that in this mode redis is in the process of loading a new dataset, and but commands are allowed and the loading flag is off. Also it need sot refer to repl-diskless-load swapdb

@oranagra oranagra added the to-be-merged should probably be merged soon label Nov 20, 2021
Copy link
Contributor

@yoav-steinberg yoav-steinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oranagra changed it based on your comments. Let me know if it makes sense.

Co-authored-by: Oran Agra <[email protected]>
Co-authored-by: yoav-steinberg <[email protected]>
@yoav-steinberg yoav-steinberg merged commit 61453f5 into redis:master Nov 27, 2021
@enjoy-binbin enjoy-binbin deleted the add_async_loading branch November 27, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to-be-merged should probably be merged soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants